Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC IKS workers upgrade should be optional #1681

Closed
tpolekhin opened this issue Jul 14, 2020 · 5 comments
Closed

VPC IKS workers upgrade should be optional #1681

tpolekhin opened this issue Jul 14, 2020 · 5 comments
Assignees

Comments

@tpolekhin
Copy link

tpolekhin commented Jul 14, 2020

When upgrading IKS version via terraform it also replaces all worker nodes in the cluster to upgrade them to the specified master version as well. This is a destructive behavior that brings your entire cluster down for an upgrade period.

Upgrading workers together with the master upgrade should be optional
https://github.com/IBM-Cloud/terraform-provider-ibm/blob/master/ibm/resource_ibm_container_vpc_cluster.go#L475

@mschenk42
Copy link
Contributor

I agree, the automatic upgrade for the workers needs to be optional. There is no way we can run this on a production cluster, especially with stateful services that need some care when upgrading. Can we help add this functionality? We have experienced Go developers that would like to help.

@hkantare
Copy link
Collaborator

@mschenk42 yes you can gohead and contribute may be we need to introduce a bool argument

@mschenk42
Copy link
Contributor

Thanks, will do. Currently testing change. Will be submitting a PR soon.

@hkantare
Copy link
Collaborator

@tpolekhin
Copy link
Author

Fixed by #1694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants