Regression on version 1.5.x for ibm_cis_firewall

[pauljegouic]

Hi there,

We are facing a regression with the resource ibm_cis_firewall that does not work with version 1.5.x

With 1.5.x :

Error:  cis_id or zone_id not passed

With 1.4.0:

ibm_cis_firewall.lockdown: Creating...
ibm_cis_firewall.lockdown: Creation complete after 2s [id=XXXXX:crn:v1:bluemix:public:internet-svcs:global:a/XXXX:XXXX-4dd5-4a55-bd53-XXXXX::]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Terraform template used for both test:

variable "region" {
  default = "eu-de"
}


provider ibm {
  region = var.region
  generation       = 1
  ibmcloud_timeout = 60
}

data "ibm_resource_group" "id" {
  name = "Default"
}

resource "ibm_cis_firewall" "lockdown" {
      cis_id        = "crn:v1:bluemix:public:internet-svcs:global:a/XXXXXXXXX"
      domain_id     = "XXXXXXXX"
      firewall_type = "lockdowns"

      lockdown {
          priority    = 1
          urls        = [
              "test.mydomain.com*"
          ]

          configurations {
              target = "ip"
              value  = "192.168.1.1"
          }
          configurations {
              target = "ip_range"
              value  = "168.78.82.5/32"
          }
      }
  }

[hkantare]

The cis firewall we changed to be inline with other CIS resources..where the domain_id should be combination of both cis_id and domain_id

[hkantare]

#1201

As part of this issue we changed the domain_id to be inline with all CIS resources...where its combination of cis_id/domain_id

[pauljegouic]

Thanks ! I missed the changelog for 1.5.0 that mentionned it.