Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view translate {x,y} for {slide, squeeze} animation #379

Merged
merged 2 commits into from
Dec 27, 2016

Conversation

tbaranes
Copy link
Member

Since the final x, y were wrong, some animations was failing. In my case, on iPad, since my view was at the bottom of the screen, doing a slide(.out, .down) the view was going out of the screen way too fast (distance = iPad height).

Less talk, more example:

Before the fix, after a slide(.out, .down):

screen shot 2016-12-22 at 09 34 18

With the fix:

screen shot 2016-12-22 at 09 44 57

Copy link
Member

@JakeLin JakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's merge it.

@lastMove
Copy link
Member

Nice One !

@tbaranes tbaranes merged commit 0d81c6e into master Dec 27, 2016
@tbaranes tbaranes deleted the hotfix/animations branch December 27, 2016 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants