Refactor multiple warning levels for same data validation filter #461
Conversation
|
The PR looks good to me, but I'm wondering how the "skipping" will work in the follow-up PR? The current approach separates one validation-item with multiple criteria/warning-levels in separate items - how will the validation know that an alternative variant of the same item was already triggered? I'm wondering if a better solution wouldn't be the other direction:
|
|
Makes sense, and yes, makes the descending severity validation sequence easier to implement. Question? in translating the legacy format to the new format, say the file contains multiple (separate) criteria for the same validation filter, but these may appear in any order in the file. It should be checked if the same type of item has been passed already and update it instead of creating a new one? That is, even if starting as separate legacy items, they end up aggregated in the object. |
Make it easy for us, implementation-wise:
|
|
|
||
| failed_validation_message = ( | ||
| "Data validation with error(s)/warning(s) " | ||
| f"""(file {(DATA_VALIDATION_TEST_DIR / f"validate_warning_{file}.yaml").relative_to(Path.cwd())}): | ||
| Criteria: variable: ['Primary Energy'], year: [2010], upper_bound: 5.0, lower_bound: 1.0 | ||
| model scenario region variable unit year value warning_level | ||
| 0 model_a scen_a World Primary Energy EJ/yr 2010 6.0 error | ||
| 1 model_a scen_b World Primary Energy EJ/yr 2010 7.0 error | ||
| 1 model_a scen_b World Primary Energy EJ/yr 2010 7.0 error""" |
There was a problem hiding this comment.
I suggest to add a third variant here where the relevant data-value of simple_df is changed to check that only the error is printed in one case and only the low-warning-level is printed in another case.
Co-authored-by: Daniel Huppmann <[email protected]>
Closes #439
Allows for a more compact writing of multiple warning level criteria (if warning level is ommitted, it defaults to error). Backwards compatible with more verbose syntax.
Stores the criteria for each level in descending order of severity (useful for upcoming PR that skips validation for lower warnings if a higher one failed).