UID2-3702 Add python config server to eks pipeline #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
6 times, most recently
from
b8ebd77 to
740524b
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
316594c to
000661a
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
85a2724 to
52c94cb
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
b4d6e24 to
19b7eeb
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
2 times, most recently
from
6366b43 to
82b8f58
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
9a950c6 to
971d328
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
3f3e30d to
761886d
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
867f221 to
1522d4c
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
e98954d to
2678241
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
bd9e27a to
5323dd6
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
38f014c to
300183b
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
524ffd6 to
64fc690
Compare
cYKatherine
commented
Jul 19, 2024
| @@ -137,7 +137,7 @@ jobs: | |||
| steps: | |||
| - name: Build Docker Image for EKS Pod | |||
| id: build_docker_image | |||
| uses: IABTechLab/uid2-operator/.github/actions/build_eks_docker_image@main | |||
| uses: IABTechLab/uid2-operator/.github/actions/build_eks_docker_image@kcc-UID2-3702-config-server | |||
There was a problem hiding this comment.
Revert this before merging
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
224e194 to
b8e1a30
Compare
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
d690302 to
8033708
Compare
cYKatherine
commented
Jul 19, 2024
| @@ -34,6 +34,7 @@ runs: | |||
| uses: actions/checkout@v4 | |||
| if: ${{ inputs.version_number_input == '' }} | |||
| with: | |||
| ref: kcc-UID2-3702-config-server | |||
There was a problem hiding this comment.
Revert this before merging
thomasm-ttd
reviewed
Jul 19, 2024
thomasm-ttd
reviewed
Jul 19, 2024
| secret_value = secret_file.read().strip() | ||
| return secret_value | ||
| except Exception as e: | ||
| return str(e), 500 |
There was a problem hiding this comment.
How will we diagnose if this is failing?
There was a problem hiding this comment.
The enclave entrypoint should fail when this value doesn't exit, and it should return with the error message and 500 status code. This will be done as a part of Ian's ticket.
thomasm-ttd
reviewed
Jul 19, 2024
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
6946166 to
65d37d1
Compare
thomasm-ttd
reviewed
Jul 22, 2024
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
e9b216f to
c32fae7
Compare
thomasm-ttd
approved these changes
Jul 22, 2024
cYKatherine
force-pushed
the
kcc-UID2-3702-config-server
branch
from
a993fdc to
cbeaa14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8s deployment change:
The eks image successfully started in the pod:
The server working:
