Ian UI d2 1728 identity buckets oom #492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasm-ttd
reviewed
Apr 16, 2024
| o.put("last_updated", APIDateTimeFormatter.format(lastUpdated)); | ||
| resp.add(o); | ||
| if (modified.size() > getMaxIdentityBucketsResponseEntries()) { | ||
| ResponseUtil.ClientError(rc, "provided since_timestamp produced large response. please provide a more recent since_timestamp or remap all with /identity/map"); |
There was a problem hiding this comment.
Assuming this text will actually be returned to the caller, can we say something like:
"The time period requested resulted in too many results. Please provide a more recent since_timestamp or re-map all with /identity/map"
jon8787
reviewed
Apr 17, 2024
| import io.vertx.core.streams.ReadStream; | ||
| import io.vertx.core.streams.WriteStream; | ||
|
|
||
| public interface IModifiedBucketEncryptStream extends ReadStream<Buffer>, WriteStream<Buffer> { |
There was a problem hiding this comment.
Might want to check UID2 Java Coding Guidelines in conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.