addmodels funcion #953
Merged
addmodels funcion #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oierlauzi
requested changes
Dec 2, 2024
|
Maybe i'd even add as a comment that the function is a bit too big and does too many things, maybe it could be splitted into smaller ones that are even easier to read and understand |
MartinSalinas98
requested changes
Dec 2, 2024
|
Thanks for all comments, I copied pasted the old code. |
MartinSalinas98
requested changes
Dec 3, 2024
MartinSalinas98
requested changes
Dec 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with new deepCenter models