Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node vesion used by Github Action. #1423

Closed
whitingjr opened this issue Mar 6, 2024 · 4 comments
Closed

Node vesion used by Github Action. #1423

whitingjr opened this issue Mar 6, 2024 · 4 comments
Assignees
Labels
type/bug Something isn't working

Comments

@whitingjr
Copy link
Collaborator

Describe the bug

Builds are failing due to the version of Node use to run the action. Currently 16.

build (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: 
actions/upload-artifact@v3
. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Node

What is the version of Node ?

16
@whitingjr whitingjr added the type/bug Something isn't working label Mar 6, 2024
@whitingjr whitingjr self-assigned this Mar 6, 2024
@whitingjr whitingjr changed the title Version bump Node vesion used by Github Action. Node vesion used by Github Action. Mar 6, 2024
@lampajr
Copy link
Member

lampajr commented Mar 14, 2024

Hey @whitingjr, I double checked and it seems that just two actions (that we are using) are still running on node16:

  • Backporting: I already tagged a new version, ie. 4.5.2 so we can simply update to that version (right now we are on 4.5.1)
  • Welcome: I opened a PR upstream, let's see if we can get that in otherwise we might consider switching to a different one.

@whitingjr
Copy link
Collaborator Author

@lampajr this is good to hear. do you want to create a PR for the Backporting action ? Then version bump Welcome when available from upstream.

@lampajr
Copy link
Member

lampajr commented Mar 15, 2024

@lampajr this is good to hear. do you want to create a PR for the Backporting action ? Then version bump Welcome when available from upstream.

Sure, here it is: #1487

@lampajr
Copy link
Member

lampajr commented Oct 21, 2024

  • Welcome: I opened a PR upstream, let's see if we can get that in otherwise we might consider switching to a different one.

Just a quick update, this has been finally merged! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants