diff --git a/src/propulsion/can/can_receiver.cpp b/src/propulsion/can/can_receiver.cpp index 867c5f16..a3ba5d8e 100644 --- a/src/propulsion/can/can_receiver.cpp +++ b/src/propulsion/can/can_receiver.cpp @@ -30,8 +30,9 @@ void CanReceiver::processNewData(utils::io::can::Frame &message) } } -bool CanReceiver::hasId(const uint32_t id, bool) +bool CanReceiver::hasId(const uint32_t id, const bool extended) { + if (extended) { return false; } for (uint32_t cobId : kCanIds) { if (cobId + node_id_ == id) { return true; } } diff --git a/src/propulsion/can/can_receiver.hpp b/src/propulsion/can/can_receiver.hpp index f9b67d5f..5f81fa3a 100644 --- a/src/propulsion/can/can_receiver.hpp +++ b/src/propulsion/can/can_receiver.hpp @@ -43,7 +43,7 @@ class CanReceiver : public utils::io::CanProccesor, public ICanReceiver { utils::io::Can &can_; IController &controller_; - static constexpr uint64_t kTimeout = 70000; // us + static constexpr uint32_t kTimeout = 70000; // us }; } // namespace hyped::propulsion diff --git a/src/propulsion/rpm_regulator.cpp b/src/propulsion/rpm_regulator.cpp index c4670fe3..2a513b5f 100644 --- a/src/propulsion/rpm_regulator.cpp +++ b/src/propulsion/rpm_regulator.cpp @@ -21,8 +21,8 @@ uint32_t RpmRegulator::calculateRpm(const data::nav_t actual_velocity, const int uint32_t RpmRegulator::calculateOptimalRpm(const data::nav_t actual_velocity) { // polynomial values from simulation - return std::round(0.32047 * actual_velocity * actual_velocity + 297.72578 * actual_velocity - + 1024.30824); + return static_cast(std::round(0.32047 * actual_velocity * actual_velocity + + 297.72578 * actual_velocity + 1024.30824)); } uint32_t RpmRegulator::step(const int32_t optimal_rpm, const int32_t actual_rpm) diff --git a/src/utils/io/spi.cpp b/src/utils/io/spi.cpp index aa41520a..3c694ae8 100644 --- a/src/utils/io/spi.cpp +++ b/src/utils/io/spi.cpp @@ -217,7 +217,7 @@ void SPI::transfer(uint8_t *tx, uint8_t *, uint16_t len) } #endif -} +} // namespace io void SPI::read(uint8_t addr, uint8_t *rx, uint16_t len) { @@ -266,6 +266,6 @@ SPI::~SPI() close(spi_fd_); } -} // namespace io } // namespace utils } // namespace hyped +} // namespace hyped diff --git a/test/state_machine/transitions.test.cpp b/test/state_machine/transitions.test.cpp index c1720250..ddb8c87c 100644 --- a/test/state_machine/transitions.test.cpp +++ b/test/state_machine/transitions.test.cpp @@ -87,7 +87,7 @@ TEST_F(TransitionFunctionality, handlesNoEmergency) motors_data.module_status = other; telemetry_data.emergency_stop_command = false; const bool has_emergency = state_machine::checkEmergency( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(has_emergency, false) << "falsely detected emergency"; } } @@ -118,7 +118,7 @@ TEST_F(TransitionFunctionality, handlesBrakeEmergency) motors_data.module_status = other; telemetry_data.emergency_stop_command = false; const bool has_emergency = state_machine::checkEmergency( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(has_emergency, true) << "failed to detect brake emergency"; } } @@ -149,7 +149,7 @@ TEST_F(TransitionFunctionality, handlesNavEmergency) motors_data.module_status = other; telemetry_data.emergency_stop_command = false; const bool has_emergency = state_machine::checkEmergency( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(has_emergency, true) << "failed to detect emergency in Navigation"; } } @@ -180,7 +180,7 @@ TEST_F(TransitionFunctionality, handlesBatteriesEmergency) motors_data.module_status = other; telemetry_data.emergency_stop_command = false; const bool has_emergency = state_machine::checkEmergency( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(has_emergency, true) << "failed to detect emergency in Batteries"; } } @@ -211,7 +211,7 @@ TEST_F(TransitionFunctionality, handlesTelemetryEmergency) motors_data.module_status = other; telemetry_data.emergency_stop_command = false; const bool has_emergency = state_machine::checkEmergency( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(has_emergency, true) << "failed to detect emergency in Telemetry"; } } @@ -242,7 +242,7 @@ TEST_F(TransitionFunctionality, handlesSensorsEmergency) motors_data.module_status = other; telemetry_data.emergency_stop_command = false; const bool has_emergency = state_machine::checkEmergency( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(has_emergency, true) << "failed to detect emergency in Sensors"; } } @@ -273,7 +273,7 @@ TEST_F(TransitionFunctionality, handlesMotorsEmergency) motors_data.module_status = data::ModuleStatus::kCriticalFailure; telemetry_data.emergency_stop_command = false; const bool has_emergency = state_machine::checkEmergency( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(has_emergency, true) << "failed to detect emergency in motors"; } } @@ -304,7 +304,7 @@ TEST_F(TransitionFunctionality, handlesStopCommand) motors_data.module_status = other; telemetry_data.emergency_stop_command = true; const bool has_emergency = state_machine::checkEmergency( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(has_emergency, true) << "failed to register stop command"; } } @@ -337,7 +337,7 @@ TEST_F(TransitionFunctionality, handlesAllInitialised) sensors_data.module_status = goal; motors_data.module_status = goal; const bool all_initialised = state_machine::checkModulesInitialised( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_initialised, true) << "failed to detect all modules being initialised"; } } @@ -369,7 +369,7 @@ TEST_F(TransitionFunctionality, handlesBrakesNotInitialised) sensors_data.module_status = goal; motors_data.module_status = goal; const bool all_initialised = state_machine::checkModulesInitialised( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_initialised, false) << "failed to detect uninitialised brakes"; } } @@ -402,7 +402,7 @@ TEST_F(TransitionFunctionality, handlesNavigationNotInitialised) sensors_data.module_status = goal; motors_data.module_status = goal; const bool all_initialised = state_machine::checkModulesInitialised( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_initialised, false) << "failed to detect Navigation not being initialised"; } } @@ -436,7 +436,7 @@ TEST_F(TransitionFunctionality, handlesBatteriesNotInitialised) sensors_data.module_status = goal; motors_data.module_status = goal; const bool all_initialised = state_machine::checkModulesInitialised( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_initialised, false) << "failed to detect Batteries not being initialised"; } } @@ -470,7 +470,7 @@ TEST_F(TransitionFunctionality, handlesTelemetryNotInitialised) sensors_data.module_status = goal; motors_data.module_status = goal; const bool all_initialised = state_machine::checkModulesInitialised( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_initialised, false) << "failed to detect Telemetry not being initialised"; } } @@ -504,7 +504,7 @@ TEST_F(TransitionFunctionality, handlesSensorsNotInitialised) sensors_data.module_status = other; motors_data.module_status = goal; const bool all_initialised = state_machine::checkModulesInitialised( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_initialised, false) << "failed to detect Sensors not being initialised"; } } @@ -538,7 +538,7 @@ TEST_F(TransitionFunctionality, handlesMotorsNotInitialised) sensors_data.module_status = goal; motors_data.module_status = other; const bool all_initialised = state_machine::checkModulesInitialised( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_initialised, false) << "failed to detect Motors not being initialise"; } } @@ -566,7 +566,7 @@ TEST_F(TransitionFunctionality, handlesAllReady) sensors_data.module_status = data::ModuleStatus::kReady; motors_data.module_status = data::ModuleStatus::kReady; const auto all_ready = state_machine::checkModulesReady( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_ready, true) << "failed to detect that all modules are ready"; } @@ -595,7 +595,7 @@ TEST_F(TransitionFunctionality, handlesBrakesNotReady) sensors_data.module_status = data::ModuleStatus::kReady; motors_data.module_status = data::ModuleStatus::kReady; const bool all_ready = state_machine::checkModulesReady( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_ready, false) << "failed to detect Brakes not being ready"; } } @@ -625,7 +625,7 @@ TEST_F(TransitionFunctionality, handlesNavigationNotReady) sensors_data.module_status = data::ModuleStatus::kReady; motors_data.module_status = data::ModuleStatus::kReady; const bool all_ready = state_machine::checkModulesReady( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_ready, false) << "failed to detect Navigation not being ready"; } } @@ -655,7 +655,7 @@ TEST_F(TransitionFunctionality, handlesBatteriesNotReady) sensors_data.module_status = data::ModuleStatus::kReady; motors_data.module_status = data::ModuleStatus::kReady; const bool all_ready = state_machine::checkModulesReady( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_ready, false) << "failed to detect Batteries not being ready"; } } @@ -684,7 +684,7 @@ TEST_F(TransitionFunctionality, handlesTelemetryNotReady) sensors_data.module_status = data::ModuleStatus::kReady; motors_data.module_status = data::ModuleStatus::kReady; const bool all_ready = state_machine::checkModulesReady( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_ready, false) << "failed to detect Telemetry not being ready"; } } @@ -714,7 +714,7 @@ TEST_F(TransitionFunctionality, handlesSensorsNotReady) sensors_data.module_status = other; motors_data.module_status = data::ModuleStatus::kReady; const bool all_ready = state_machine::checkModulesReady( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_ready, false) << "failed to detect Sensors not being ready"; } } @@ -744,7 +744,7 @@ TEST_F(TransitionFunctionality, handlesMotorsNotReady) sensors_data.module_status = data::ModuleStatus::kReady; motors_data.module_status = other; const bool all_ready = state_machine::checkModulesReady( - log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); + log_, brakes_data, nav_data, batteries_data, telemetry_data, sensors_data, motors_data); ASSERT_EQ(all_ready, false) << "failed to detect Motors not being ready"; } }