You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In French, there are 2 words for "year": "an" and "année". Their meanings are slightly different (see here), but each one has singular and plural forms.
Currently if one calls TimeSpan.FromDays(days).Humanize(maxUnit: TimeUnit.Year) using French culture, they'll get
"1 année" if days = 366
"2 ans" if days = 731
Nothing justifies that discrepancy. I suggest we replace (in Resources.fr.resx) "1 année" with "1 an", to make it consistent with the plural form.
In French, "0 <time unit>" should use the singular form
Unlike English, where you would write "0 milliseconds", in French you would write "0 milliseconde" (no 's' at the end).
Currently if you call TimeSpan.Zero.Humanize() you will get "0 millisecondes".
TimeSpan.Zero.Humanize(toWords: true) yields "pas de temps"
This may be more subjective, but to me "pas de temps" does not sound natural. I recommend "temps nul" or "durée nulle" instead.
I already have made the necessary changes. A PR will ensue shortly.
The text was updated successfully, but these errors were encountered:
Inconsistency between "1 année" and "2 ans"
In French, there are 2 words for "year": "an" and "année". Their meanings are slightly different (see here), but each one has singular and plural forms.
Currently if one calls
TimeSpan.FromDays(days).Humanize(maxUnit: TimeUnit.Year)
using French culture, they'll getNothing justifies that discrepancy. I suggest we replace (in Resources.fr.resx) "1 année" with "1 an", to make it consistent with the plural form.
In French, "0 <time unit>" should use the singular form
Unlike English, where you would write "0 milliseconds", in French you would write "0 milliseconde" (no 's' at the end).
Currently if you call
TimeSpan.Zero.Humanize()
you will get "0 millisecondes".TimeSpan.Zero.Humanize(toWords: true) yields "pas de temps"
This may be more subjective, but to me "pas de temps" does not sound natural. I recommend "temps nul" or "durée nulle" instead.
I already have made the necessary changes. A PR will ensue shortly.
The text was updated successfully, but these errors were encountered: