Measure of length #775
Open
Measure of length #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the corresponding powers of ten as underlying values.
…icPrefix.Undefined as null equivaltent and default value for API parameter.
…he functionality of maxPrefix.
…t be undesireable.
|
|
clairernovotny
requested changes
Mar 4, 2019
| @@ -1,8 +1,8 @@ | |||
| // Wrote by Alois de Gouvello https://github.com/aloisdg | |||
| // Written by Alois de Gouvello https://github.com/aloisdg with additions by Jonas Barkå https://github.com/JonasBarka. | |||
There was a problem hiding this comment.
The copyrights at the top of the file, if any, should be simply Copyright (c) .NET Foundation and Contributors
Alternatively, it can be removed as it's in the project root.
|
|
||
| // The MIT License (MIT) | ||
|
|
||
| // Copyright (c) 2015 Alois de Gouvello | ||
| // Copyright (c) 2015-2019 Alois de Gouvello and each other contributor for their respective work. | ||
|
|
|
@JonasBarka do you still want this one merged? if so can you address the comments and rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526
Here is a checklist you should tick through before submitting a pull request:
devbranch (more info below). Based on latest master.fixes #<the issue number>build.cmdorbuild.ps1and ensure there are no test failuresNote the interaction between parameters
decimalsandminPrefixas described in the comment to one of the unit tests.Only
maxPrefixandminPrefixare new options, but I added all options to the readme description ofToMetric.