Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dotnet TFM #451

Closed
devhawk opened this issue Aug 4, 2015 · 9 comments
Closed

Support dotnet TFM #451

devhawk opened this issue Aug 4, 2015 · 9 comments
Assignees
Milestone

Comments

@devhawk
Copy link

devhawk commented Aug 4, 2015

Humanizer is currently not compatible with .NET Core / ASP.NET 5. Given it's a PCL, I suspect that .NET core support is primarily a matter of updating how the NuGet package is built and not much (if any) in the way of source code changes.

Details on new dotnet TFM are here: http://oren.codes/2015/07/29/targeting-net-core/

@MehdiK
Copy link
Member

MehdiK commented Aug 22, 2015

Thanks @devhawk. Yeah, we should do this sooner than later. Thanks for the pointer. Will check it out.

@clairernovotny
Copy link
Member

@MehdiK, do you want a PR for this? What this really needs is just to be a Profile 259 PCL and an updated Nuspec with the dependencies listed out.

If you still want to support the .NET 4 Client Profile (does anyone really use this?), and/or .NET 4, then I can create another "head" project and move the real files into a Shared Project. That would create the least amount of duplication.

If that works, I can have that over to you very quickly.

@MehdiK
Copy link
Member

MehdiK commented Aug 27, 2015

Thanks @onovotny. A PR would be nice.

For now let's do the simplest thing that works and stay away from .Net 4 Client Profile. I don't even know if any of the users use it.

@clairernovotny
Copy link
Member

Can I bump the min .net ver in the PCL to 4.5 (it's currently 4.0). That would be the easiest thing, otherwise I need a second pcl that has 4.5 as a minimum.

@MehdiK
Copy link
Member

MehdiK commented Sep 2, 2015

That's a major change and I honestly don't feel comfortable making it as part of V1. I am not a big fan of shared project either.

Maybe we should just start a V2 pre-release!

@MehdiK MehdiK added this to the V2 milestone Sep 22, 2015
@PhyxionNL
Copy link
Contributor

I still use .NET 4 CP. It's necessary to support XP / unpatched Vista & 7.

@clairernovotny clairernovotny self-assigned this Oct 19, 2015
@clairernovotny
Copy link
Member

This is now done in commit be6bc12 in the dev branch. Package is on appveyor CI feed

@clairernovotny
Copy link
Member

Guess it'd help I put a link to the CI build feed: https://ci.appveyor.com/project/onovotny/humanizer

@clairernovotny
Copy link
Member

There's also a MyGet feed now for pre-release builds: https://www.myget.org/feed/Packages/humanizer
I'll update the docs to mention that too

@clairernovotny clairernovotny mentioned this issue Dec 18, 2015
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants