Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NumberToWordsConverter and Formatter to use GrammaticalNumberDetector #192

Open
hazzik opened this issue Apr 11, 2014 · 5 comments

Comments

@hazzik
Copy link
Member

hazzik commented Apr 11, 2014

I suggest to add IGrammaticalNumberDetector which will be used to determine suffixes (Singular, Dual, Paucal, Plural, etc) in formatters and to use same logic where appropriate (Russian, Polish, Arabic, etc)

@hazzik
Copy link
Member Author

hazzik commented Apr 11, 2014

Also I suggest to refactor DateTime and TimeSpan humanization to use ToQuantity extension.

Created #205 to deal with this.

@thunsaker
Copy link
Contributor

👍

@mexx
Copy link
Collaborator

mexx commented Apr 12, 2014

👍 as it would be the next step to better design

@MehdiK
Copy link
Member

MehdiK commented Apr 12, 2014

👍

@SimonCropp
Copy link
Collaborator

@hazzik still think this is worthwhile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants