Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe navigator for nil responses #232

Open
kitebuggy opened this issue Aug 4, 2021 · 0 comments
Open

Safe navigator for nil responses #232

kitebuggy opened this issue Aug 4, 2021 · 0 comments

Comments

@kitebuggy
Copy link

kitebuggy commented Aug 4, 2021 •
edited
Loading

Hello,

Seems hardly worth submitting a PR for this one. I've come across instances of a nil response, so would recommend adding a safe navigator to this call, ie:

initialize_from(response&.with_indifferent_access)

hubspot-ruby/lib/hubspot/resource.rb

Line 137 in 8eb0a64

initialize_from(response.with_indifferent_access)

Thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kitebuggy