Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the default branch to the current live version and remove unused branches #62

Open
takahirox opened this issue Mar 24, 2022 · 6 comments

Comments

@takahirox
Copy link

We should clean up our branches. There are a lot of (maybe) unused ones.

And the default branch hubs/master is old. It's Three.js r111 based while the live version used by Hubs is r133 based.

So I would like to suggest remove branches except for hubs-patches (our custom patches for Hubs) and hubs-patches-133 (the live version cosisted of Three.js r133 + our patches) and to switch the default branch to the current live version.

@brianpeiris
Copy link

I have these branches that I used to explain the changes we made on top of three.js, but we've moved on to a new process now, so feel free to delete them. You can also delete the wiki page if it's no longer useful. https://github.com/MozillaReality/three.js/wiki/Modifications-on-top-of-three.js

image

@takahirox
Copy link
Author

Thanks for the comment. The branches are not used even by Spoke or other our libs? I noticed that some branches are for patching to glTF exporter.

@brianpeiris
Copy link

brianpeiris commented Apr 4, 2022

None of the patch-* branches are referenced by other repos, so they should be safe to delete.
Looks like Spoke refers directly to a commit, not a branch, so deleting any branches should not affect it either.
three-batch-manager references the hubs/master branch, but actually I think we should remove three-batch-manager as a dependency of Hubs, since I think it's not actually in use.

@takahirox
Copy link
Author

takahirox commented Apr 4, 2022

Thanks.

Looks like Spoke refers directly to a commit, not a branch, so deleting any branches should not affect it either.

The commit Spoke refers to doesn't seem to be merged to the live version but is in hubs/feature/plugin-api branch 0f9b002 so just in case I want to keep that branch so far.

three-batch-manager references the hubs/master branch, but actually I think we should remove three-batch-manager as a dependency of Hubs, since I think it's not actually in use.

If I remember correctly, three-batch-manager is disabled in Hubs Client but it's still active in Spoke, is it true? I have forcely pushed hubs-patches-133 to hubs/master before reading the response. I need to check if Spoke works with hubs-patches-133...

Update: Restored hubs/master branch.

@takahirox
Copy link
Author

@brianpeiris I have deleted the wiki page because at least it looks out dated. Let's make a new one if we still need "how to apply our patch on the top of the official Three.js".

@brianpeiris
Copy link

Sounds good to me. Yeah it would be good to document our current approach for updating three.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants