-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch the default branch to the current live version and remove unused branches #62
Comments
I have these branches that I used to explain the changes we made on top of three.js, but we've moved on to a new process now, so feel free to delete them. You can also delete the wiki page if it's no longer useful. https://github.com/MozillaReality/three.js/wiki/Modifications-on-top-of-three.js |
Thanks for the comment. The branches are not used even by Spoke or other our libs? I noticed that some branches are for patching to glTF exporter. |
None of the |
Thanks.
The commit Spoke refers to doesn't seem to be merged to the live version but is in
If I remember correctly, Update: Restored |
@brianpeiris I have deleted the wiki page because at least it looks out dated. Let's make a new one if we still need "how to apply our patch on the top of the official Three.js". |
Sounds good to me. Yeah it would be good to document our current approach for updating three.js |
We should clean up our branches. There are a lot of (maybe) unused ones.
And the default branch
hubs/master
is old. It's Three.js r111 based while the live version used by Hubs is r133 based.So I would like to suggest remove branches except for
hubs-patches
(our custom patches for Hubs) andhubs-patches-133
(the live version cosisted of Three.js r133 + our patches) and to switch the default branch to the current live version.The text was updated successfully, but these errors were encountered: