Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kicking should remove entities that the kicked user created, not owned #864

Closed
brianpeiris opened this issue Feb 1, 2019 · 0 comments
Closed

Comments

@brianpeiris
Copy link
Contributor

We introduced kicking in #861 but that implementation removes all entities for with the kicked user is currently the owner. Instead, we should keep store creator client ids when entities are spawned and remove only the objects that the kicked user created, not the ones they currently own.

This applies to pinned entities as well -- if a kicked user pinned an object that another user created, the entity should not be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant