[Mobile] Waypoints and links are not working for other users if the “Create and move objects” setting is disabled

[Softvision-GeluHaiduc]

[Affected Versions]:

• Firefox for Android 92.1.1
• Chrome 94.0.4606.61

[Affected Platforms]:

• Android 11

[Prerequisites]:

• Have the room with the “Create and move objects” setting disabled. (https://hubs.mozilla.com/ZVjLfWE/trained-tempting-volume)

[Steps to reproduce]:

1. Enter the room from preconditions.
2. Try using a waypoint.
3. Try opening a link to another website.
4. Observe the behavior.

[Expected results]:

• The waypoint and links work as expected for other users.

[Actual results]:

• The waypoint and links don’t work for other users.

[Notes]:

• The issue is not reproducible on PC.

┆Issue is synchronized with this Jira Task

[johnshaughnessy]

I think the canMove here is too restrictive. Will test something like this later today:

Unstaged changes (1)
modified   src/systems/userinput/devices/app-aware-touchscreen.js
@@ -36,6 +36,10 @@ const getPlayerCamera = (() => {
   };
 })();
 
+function isSingleActionButton(el) {
+  return el.components.tags && el.components.tags.data.singleActionButton;
+}
+
 function shouldMoveCursor(touch, rect, raycaster) {
   const isCursorGrabbing = !!AFRAME.scenes[0].systems.interaction.state.rightRemote.held;
   if (isCursorGrabbing) {
@@ -74,7 +78,7 @@ function shouldMoveCursor(touch, rect, raycaster) {
     (isFrozen || !isPinned) &&
     !isStaticControlledMedia &&
     !isStaticMedia &&
-    (remoteHoverTarget && canMove(remoteHoverTarget))
+    (remoteHoverTarget && (canMove(remoteHoverTarget) || isSingleActionButton(remoteHoverTarget)))
   );
 }

[takahirox]

@Softvision-GeluHaiduc

#4740 should fix the problem. Just in case, would you do double check on your end, too?

[Softvision-RemusDranca]

I have verified the issue and it's no longer reproducible. The links and waypoints are now working while the “Create and move objects” setting is disabled.
Tested on Windows 10 using Chrome(94) and Firefox(93), macOS(Big Sur 11.6) using Safari(15.0), iOS (15.0.1) with Safari Android (11) using Chrome(94) and Firefox(92.1.1).