Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Scene Editor" does not appear in non-English languages on Hubs Cloud #4268

Closed
johnshaughnessy opened this issue May 19, 2021 · 3 comments · Fixed by #5464
Closed

"Scene Editor" does not appear in non-English languages on Hubs Cloud #4268

johnshaughnessy opened this issue May 19, 2021 · 3 comments · Fixed by #5464
Labels
accessibility Issues related to improving accessibility of Hubs bug good first issue has-repro This has been reproduced using steps in the bug jira-hubs P2 Address when able

Comments

@johnshaughnessy
Copy link
Contributor

johnshaughnessy commented May 19, 2021

Description
When users set their preferred locale to something other than English, the link to the scene editor does not appear on the home page.

I suspect the same might be true for some of the other translations that are not part of the default translation files:

https://github.com/mozilla/hubs/blob/5f204a029b1f451031cc18a9eb9f0f85a1b5e8f8/src/schema.toml#L3-L13

To Reproduce
Steps to reproduce the behavior:

  1. Go to Hubs Cloud home page
  2. Enable scene editor in admin panel
  3. Enter room
  4. Go to preferences
  5. Select non-English language preference
  6. Go to Hubs Cloud home page
  7. There is no link to the Scene Editor

Expected behavior
A link to Spoke with a translated version of "Scene Editor" should appear on the home page. If there is no available translation in the target language, then the English words "Scene Editor" should appear instead.

Screenshots
image

Hardware

  • Device: [e.g. Desktop, phone, VR headset]
  • OS: [e.g. Windows, iOS, Linux]
  • Browser: [e.g. Firefox]

Additional context

./src/schema.toml:13:translations.en."editor-name" = { category = "translations", type = "string", internal = "true" }
./src/react-components/room/SceneUrlModalContainer.js:30:      editorName={configs.translation("editor-name")}
./src/react-components/layout/PageContainer.js:17:      editorName={configs.translation("editor-name")}
./src/react-components/scene-ui.js:250:                    values={{ editorName: configs.translation("editor-name") }}
./src/react-components/scene-ui.js:265:                      values={{ editorName: configs.translation("editor-name") }}
./src/react-components/media-browser.js:428:                    {configs.translation("editor-name")}
./src/react-components/media-browser.js:525:                      values={{ editorName: configs.translation("editor-name") }}
./src/utils/i18n.js:7:  "editor-name": "Scene Editor",

┆Issue is synchronized with this Jira Task

@johnshaughnessy johnshaughnessy added bug needs triage For bugs that have not yet been assigned a fix priority accessibility Issues related to improving accessibility of Hubs good first issue has-repro This has been reproduced using steps in the bug P2 Address when able and removed needs triage For bugs that have not yet been assigned a fix priority labels May 19, 2021
@himanshu007-creator
Copy link

Hi, i would like to work on this issue. But i dont know how to fix it

@ArneKossmann
Copy link

Hi, I run into the same issue with the german translation.
Somehow configs.translation("editor-name") returns a empty string for Non-Englisch languages.
But configs.translation() also search the current translation.
You can fix this by adding a "editor-name" entry to the translation files.
e.g. ./assets/locales/de.json
"editor-name": "Szenen Editor"

@sarhugo
Copy link
Contributor

sarhugo commented May 26, 2022

Hi, I'll look into this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to improving accessibility of Hubs bug good first issue has-repro This has been reproduced using steps in the bug jira-hubs P2 Address when able
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants