Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortlinks for invite codes do not show 'Open Room' when pasted into the spaces #1246

Closed
misslivirose opened this issue Apr 18, 2019 · 2 comments · Fixed by #1615 or #2095
Closed

Shortlinks for invite codes do not show 'Open Room' when pasted into the spaces #1246

misslivirose opened this issue Apr 18, 2019 · 2 comments · Fixed by #1615 or #2095
Labels
bug has-repro This has been reproduced using steps in the bug P2 Address when able

Comments

@misslivirose
Copy link
Contributor

misslivirose commented Apr 18, 2019

image

Instead, the short link gives a blank gray-blue rectangle and shows 'Open Link' when 'Open Room' is expected

@misslivirose
Copy link
Contributor Author

Update: in trying this again, shortlinks for invite codes now do not resolve at all.

Repro:

  1. Open the 'Share' button
  2. Paste the hub.link url into a room

Expected: the url resolves to a Hubs room and shows 'Open Room'
Actual: broken link image

image

@misslivirose misslivirose added has-repro This has been reproduced using steps in the bug P2 Address when able labels Aug 6, 2019
@johnshaughnessy johnshaughnessy self-assigned this Aug 6, 2019
@johnshaughnessy
Copy link
Contributor

johnshaughnessy commented Aug 9, 2019

I only fixed the client side of this issue by changing the regex that recognizes a room link, but there still seems to be a problem that if I post a room link without an https:// prefix, the media won't resolve with a thumbnail for the room and instead it will be a broken image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug has-repro This has been reproduced using steps in the bug P2 Address when able
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants