From 6883bd4bd0ec47bbbfdb365b07672854be14a1e5 Mon Sep 17 00:00:00 2001 From: John Shaughnessy Date: Fri, 10 Sep 2021 16:14:49 -0700 Subject: [PATCH 1/3] Add a theme variable accent4-border-color This is a proof-of-concept PR for exposing button border colors in the theme configs. --- src/react-components/input/ToolbarButton.scss | 3 +- src/react-components/styles/global.scss | 1 + src/react-components/styles/theme.scss | 1 + themes.json | 129 +++++++++++++++++- 4 files changed, 132 insertions(+), 2 deletions(-) diff --git a/src/react-components/input/ToolbarButton.scss b/src/react-components/input/ToolbarButton.scss index ebaa982d7a..e68bdf1846 100644 --- a/src/react-components/input/ToolbarButton.scss +++ b/src/react-components/input/ToolbarButton.scss @@ -506,7 +506,8 @@ :local(.accent4) { :local(.icon-container) { background-color: theme.$accent4-color; - } + border-color: theme.$accent4-border-color; // TODO: Fix border color for selected, hovered, and active + } &:hover :local(.icon-container) { background-color: theme.$accent4-color-hover; diff --git a/src/react-components/styles/global.scss b/src/react-components/styles/global.scss index d828fc7c84..10d9521628 100644 --- a/src/react-components/styles/global.scss +++ b/src/react-components/styles/global.scss @@ -54,6 +54,7 @@ --accent4-color: #{theme.$blue}; --accent4-color-hover: #{theme.$blue-hover}; --accent4-color-pressed: #{theme.$blue-pressed}; + --accent4-border-color: var(--accent4-color); --accent5-color: #{theme.$purple}; --accent5-color-hover: #{theme.$purple-hover}; diff --git a/src/react-components/styles/theme.scss b/src/react-components/styles/theme.scss index 892aa4c494..4aa5839983 100644 --- a/src/react-components/styles/theme.scss +++ b/src/react-components/styles/theme.scss @@ -138,6 +138,7 @@ $accent3-color-pressed: var(--accent3-color-pressed); $accent4-color: var(--accent4-color); $accent4-color-hover: var(--accent4-color-hover); $accent4-color-pressed: var(--accent4-color-pressed); +$accent4-border-color: var(--accent4-border-color); $accent5-color: var(--accent5-color); $accent5-color-hover: var(--accent5-color-hover); diff --git a/themes.json b/themes.json index 396388441c..b8c6a10bb4 100644 --- a/themes.json +++ b/themes.json @@ -3,7 +3,8 @@ "id": "hubs-default", "default": true, "name": "Hubs Default", - "variables": {} + "variables": { + } }, { "id": "hubs-dark-mode", @@ -41,5 +42,131 @@ "background-hover-color": "#aaaaaa", "notice-background-color": "#2f80ed" } + }, + { + "variables": { + "tip-button-color-hover": "#ffffff", + "loading-screen-background": "radial-gradient(50% 50% at 50% 50%, #15171B 0%, #282C31 100%)", + "background4-color": "#5D646C", + "accept-color-pressed": "#21242C", + "accent4-color": "#2B313B", + "accent4-border-color": "red", + "accent5-color": "#2B313B", + "border3-color": "#5D646C", + "primary-color-hover": "#12A4ED", + "outline-color": "#ffffff", + "text1-color-hover": "#E7E7E7", + "border2-color": "#5D646C", + "text1-color-pressed": "#DBDBDB", + "accent2-color": "#2B313B", + "accent1-color": "#2B313B", + "basic-color-pressed": "#636F80", + "secondary-color-pressed": "#282C31", + "accent3-color-pressed": "#21242C", + "text3-color-hover": "#C7C7C7", + "text2-color-pressed": "#DBDBDB", + "text3-color-pressed": "#ADADAD", + "accent5-color-hover": "#5D646C", + "text2-color-hover": "#F5F5F5", + "secondary-color": "#3A4048", + "background2-color": "#21242C", + "action-color-highlight": "#ff74a4", + "text4-color": "#E7E7E7", + "active-color-hover": "#12A4ED", + "background1-color": "#2B313B", + "basic-border-color": "#5D646C", + "accept-color-hover": "#5D646C", + "accent3-color": "#2B313B", + "border1-color": "#3A4048", + "accept-color": "#2B313B", + "text1-color": "#ffffff", + "active-text-color": "#2B313B", + "text3-color": "#BBBBBB", + "accent1-color-pressed": "#21242C", + "background-hover-color": "#aaaaaa", + "notice-background-color": "#2f80ed", + "accent4-color-hover": "#5D646C", + "background3-color": "#3A4048", + "primary-color": "#12A4ED", + "accent5-color-pressed": "#21242C", + "accent3-color-hover": "#5D646C", + "accent4-color-pressed": "#21242C", + "basic-color": "#3A4048", + "accent2-color-hover": "#5D646C", + "accent2-color-pressed": "#21242C", + "input-bg-color": "#21242C", + "basic-color-hover": "#4B5562", + "tip-text-color": "#2B313B", + "tip-bg-color": "#12A4ED", + "accent1-color-hover": "#5D646C", + "text2-color": "#E7E7E7", + "secondary-color-hover": "#5D646C", + "action-color": "#ff3464" + }, + "name": "Matt Croud Mode for the Magically Enhanced", + "id": "hubs-croud-mode" + }, + + { + "variables": { + "tip-button-color-hover": "#ffffff", + "loading-screen-background": "radial-gradient(50% 50% at 50% 50%, #15171B 0%, #282C31 100%)", + "background4-color": "#5D646C", + "accept-color-pressed": "#21242C", + "accent4-color": "#2B313B", + "accent5-color": "#2B313B", + "border3-color": "#5D646C", + "primary-color-hover": "#12A4ED", + "outline-color": "#ffffff", + "text1-color-hover": "#E7E7E7", + "border2-color": "#5D646C", + "text1-color-pressed": "#DBDBDB", + "accent2-color": "#2B313B", + "accent1-color": "#2B313B", + "basic-color-pressed": "#636F80", + "secondary-color-pressed": "#282C31", + "accent3-color-pressed": "#21242C", + "text3-color-hover": "#C7C7C7", + "text2-color-pressed": "#DBDBDB", + "text3-color-pressed": "#ADADAD", + "accent5-color-hover": "#5D646C", + "text2-color-hover": "#F5F5F5", + "secondary-color": "#3A4048", + "background2-color": "#21242C", + "action-color-highlight": "#ff74a4", + "text4-color": "#E7E7E7", + "active-color-hover": "#12A4ED", + "background1-color": "#2B313B", + "basic-border-color": "#5D646C", + "accept-color-hover": "#5D646C", + "accent3-color": "#2B313B", + "border1-color": "#3A4048", + "accept-color": "#2B313B", + "text1-color": "#ffffff", + "active-text-color": "#2B313B", + "text3-color": "#BBBBBB", + "accent1-color-pressed": "#21242C", + "background-hover-color": "#aaaaaa", + "notice-background-color": "#2f80ed", + "accent4-color-hover": "#5D646C", + "background3-color": "#3A4048", + "primary-color": "#12A4ED", + "accent5-color-pressed": "#21242C", + "accent3-color-hover": "#5D646C", + "accent4-color-pressed": "#21242C", + "basic-color": "#3A4048", + "accent2-color-hover": "#5D646C", + "accent2-color-pressed": "#21242C", + "input-bg-color": "#21242C", + "basic-color-hover": "#4B5562", + "tip-text-color": "#2B313B", + "tip-bg-color": "#12A4ED", + "accent1-color-hover": "#5D646C", + "text2-color": "#E7E7E7", + "secondary-color-hover": "#5D646C", + "action-color": "#ff3464" + }, + "name": "Jomb", + "id": "hubs-jomb-mode" } ] From 2e65f93ca7314917018abcb16fed167fb16cb516 Mon Sep 17 00:00:00 2001 From: Matthew Cool Date: Thu, 16 Sep 2021 21:40:04 -0700 Subject: [PATCH 2/3] toolbar button theme adjustments, edits to dark mode theme --- src/react-components/input/Button.stories.js | 2 +- src/react-components/input/ToolbarButton.scss | 31 +-- src/react-components/styles/global.scss | 9 +- src/react-components/styles/theme.scss | 10 +- themes.json | 181 +++++------------- 5 files changed, 78 insertions(+), 155 deletions(-) diff --git a/src/react-components/input/Button.stories.js b/src/react-components/input/Button.stories.js index cd831cc0e5..53f3190c0a 100644 --- a/src/react-components/input/Button.stories.js +++ b/src/react-components/input/Button.stories.js @@ -51,7 +51,7 @@ export const Tokens = () => ( export const Landing = () => (