Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for java records #1163

Open
bdshadow opened this issue Feb 27, 2024 · 1 comment
Open

Add support for java records #1163

bdshadow opened this issue Feb 27, 2024 · 1 comment

Comments

@bdshadow
Copy link

public record MyRecord(String recordName) {

	/**
	 * without explicit getter Jinjava doesn't see it
	 */
	public String getRecordName() {
		return recordName;
	}
}

The following template won't be correctly filled without the getter, although it's not needed for records

{{ myRecord.recordName }}

I tried to contribute, but it turned out, that the java version in the base pom.xml is still 8. https://github.com/HubSpot/basepom/blob/master/pom.xml#L17. I think such change must be done by the core maintainers, who know all of the possible implications.

It's 2024, time to go for java 21+

@jasmith-hs
Copy link
Contributor

We are thinking of doing a major version release and bumping to Java 17 very soon, and then not too long after that we can bump to Java 21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants