Automatic token refreshing

[vvitto]

Hi. I've investigated codebase of the gem and seems there is not mechanism for auto refreshing access token when it gets expired. I use the hubspot client in many services and it becomes a little annoying to copy paste code with handing exceptions. Here is a basic example of how it works:

def call
    client = ::Hubspot::Client.new(access_token: integration.access_token)
    client.crm.contacts.basic_api.get_by_id(contact_id:)
   ...
rescue Hubspot::Crm::Contacts::ApiError => e
    if expired?(e)
      Integration::HubspotIntegration::RefreshAccessToken.call(integration:)
      retry
    end
end

def expired?(error)
    JSON.parse(error.response_body)['category'] == 'EXPIRED_AUTHENTICATION'
end

So what would be nice to have:

• Automatically refresh access token once it gets expired.
• Retry request one more time with fresh access token.
• Be able to pass lambda or proc into constructor that will be called with refreshed token.

Example:

client = ::Hubspot::Client.new(
   access_token: integration.access_token,
   refresh_token: integration.refresh_token,
   client_id: integration.client_id,
   client_secret: integration.client_secret,
   redirect_uri: integration.redirect.uri,
   authentication_callback: ->(response) do
        integration.update!(
          access_token: response.access_token,
          refresh_token: response.refresh_token
        )
)

I can add this feature by myself if you don't mind and can guide me a little bit, or maybe you know some other ways how to solve my problem?

[alzheltkovskiy-hubspot]

Hi @vvitto. Thank you for the interesting proposal, we will discuss this with the team and give you an answer.

[alzheltkovskiy-hubspot]

Hi @vvitto. We discussed this with the team and came to the conclusion that this is not a bad idea. We will try to implement it after we resolve our current issues.