From 5942177f7274cc40bf645413dc27027dcc17bbc8 Mon Sep 17 00:00:00 2001
From: Ray Mattingly <rmdmattingly@gmail.com>
Date: Thu, 15 Dec 2022 17:52:49 -0500
Subject: [PATCH] HBASE-27253 make slowlog configurations dynamic (#4926)

Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org>
---
 .../apache/hadoop/hbase/ipc/RpcServer.java    | 42 +++++++++++++++----
 1 file changed, 35 insertions(+), 7 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
index daa71d5983c7..39aca2c54fb1 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
@@ -92,7 +92,7 @@ public abstract class RpcServer implements RpcServerInterface, ConfigurationObse
   private static final String MULTI_SERVICE_CALLS = "multi.service_calls";
 
   private final boolean authorize;
-  private final boolean isOnlineLogProviderEnabled;
+  private volatile boolean isOnlineLogProviderEnabled;
   protected boolean isSecurityEnabled;
 
   public static final byte CURRENT_VERSION = 0;
@@ -196,8 +196,8 @@ public abstract class RpcServer implements RpcServerInterface, ConfigurationObse
   protected static final Gson GSON = GsonUtil.createGsonWithDisableHtmlEscaping().create();
 
   protected final int maxRequestSize;
-  protected final int warnResponseTime;
-  protected final int warnResponseSize;
+  protected volatile int warnResponseTime;
+  protected volatile int warnResponseSize;
 
   protected final int minClientRequestTimeout;
 
@@ -275,8 +275,8 @@ public RpcServer(final Server server, final String name,
     this.maxQueueSizeInBytes =
       this.conf.getLong("hbase.ipc.server.max.callqueue.size", DEFAULT_MAX_CALLQUEUE_SIZE);
 
-    this.warnResponseTime = conf.getInt(WARN_RESPONSE_TIME, DEFAULT_WARN_RESPONSE_TIME);
-    this.warnResponseSize = conf.getInt(WARN_RESPONSE_SIZE, DEFAULT_WARN_RESPONSE_SIZE);
+    this.warnResponseTime = getWarnResponseTime(conf);
+    this.warnResponseSize = getWarnResponseSize(conf);
     this.minClientRequestTimeout =
       conf.getInt(MIN_CLIENT_REQUEST_TIMEOUT, DEFAULT_MIN_CLIENT_REQUEST_TIMEOUT);
     this.maxRequestSize = conf.getInt(MAX_REQUEST_SIZE, DEFAULT_MAX_REQUEST_SIZE);
@@ -297,8 +297,7 @@ public RpcServer(final Server server, final String name,
       saslProps = Collections.emptyMap();
     }
 
-    this.isOnlineLogProviderEnabled = conf.getBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY,
-      HConstants.DEFAULT_ONLINE_LOG_PROVIDER_ENABLED);
+    this.isOnlineLogProviderEnabled = getIsOnlineLogProviderEnabled(conf);
     this.scheduler = scheduler;
   }
 
@@ -311,6 +310,35 @@ public void onConfigurationChange(Configuration newConf) {
     if (authorize) {
       refreshAuthManager(newConf, new HBasePolicyProvider());
     }
+    refreshSlowLogConfiguration(newConf);
+  }
+
+  private void refreshSlowLogConfiguration(Configuration newConf) {
+    boolean newIsOnlineLogProviderEnabled = getIsOnlineLogProviderEnabled(newConf);
+    if (isOnlineLogProviderEnabled != newIsOnlineLogProviderEnabled) {
+      isOnlineLogProviderEnabled = newIsOnlineLogProviderEnabled;
+    }
+    int newWarnResponseTime = getWarnResponseTime(newConf);
+    if (warnResponseTime != newWarnResponseTime) {
+      warnResponseTime = newWarnResponseTime;
+    }
+    int newWarnResponseSize = getWarnResponseSize(newConf);
+    if (warnResponseSize != newWarnResponseSize) {
+      warnResponseSize = newWarnResponseSize;
+    }
+  }
+
+  private static boolean getIsOnlineLogProviderEnabled(Configuration conf) {
+    return conf.getBoolean(HConstants.SLOW_LOG_BUFFER_ENABLED_KEY,
+      HConstants.DEFAULT_ONLINE_LOG_PROVIDER_ENABLED);
+  }
+
+  private static int getWarnResponseTime(Configuration conf) {
+    return conf.getInt(WARN_RESPONSE_TIME, DEFAULT_WARN_RESPONSE_TIME);
+  }
+
+  private static int getWarnResponseSize(Configuration conf) {
+    return conf.getInt(WARN_RESPONSE_SIZE, DEFAULT_WARN_RESPONSE_SIZE);
   }
 
   protected void initReconfigurable(Configuration confToLoad) {