added support for GraphQL #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Huachao
reviewed
Jul 9, 2019
Huachao
reviewed
Jul 9, 2019
src/utils/httpRequestParser.ts
Outdated
|
|
||
| let graphQlPayload = { | ||
| query: body, | ||
| variables: JSON.parse(variables.toString()) |
There was a problem hiding this comment.
If no variables provided, do we still need to serialize this, or if we included variables: null in the payload, will the GraphQL server allow this?
There was a problem hiding this comment.
yes, it still needs to be sent. I've never personally used a request without variables, but I'll add a default state
Repository owner
deleted a comment from
ferronrsmith
Jul 9, 2019
Huachao
reviewed
Jul 9, 2019
|
|
||
| let graphQlPayload = { | ||
| query: body, | ||
| variables: variables ? JSON.parse(variables.toString()) : {} |
There was a problem hiding this comment.
Or the variables should be omitted if variables not provided? I think the variables field is optional
There was a problem hiding this comment.
Sorry, my comment got deleted. Some GraphQL servers do schema validation checks for {query,variables}. I'd rather send it, even if it's empty.
|
@ferronrsmith Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.