Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers overlap when response length > 99 lines long #58

Closed
sfertman opened this issue Jan 9, 2017 · 4 comments
Closed

Line numbers overlap when response length > 99 lines long #58

sfertman opened this issue Jan 9, 2017 · 4 comments
Labels

Comments

@sfertman
Copy link

sfertman commented Jan 9, 2017

Great plugin guys! I use it everyday for work.
TL;DR:

  • VSCode Version: 1.8.1
  • OS Version: Ubuntu 16.04
  • REST Client Version: 0.11.4

Steps to Reproduce:

  • Run a request that returns a response that is longer than 99 lines

More details

When REST-client receives a response with more than 99 lines, some of the numbers are rendered one on top of the other (see screenshot)
screenshot from 2017-01-09 11-26-09

I also noticed that rendering a long request (~2500 lines in my case) takes quite a bit if time (~1min) and when scrolling up/down to view, it is sluggish and laggy. This is similar to described in #56 in the sense that it is not a network issue (response time is ~0.5sec); however, response size is quite small compared with 10MB discussed there:
image
Let me know if you require more details.
Thanks.

@Huachao
Copy link
Owner

Huachao commented Jan 9, 2017

@sfertman thanks for your usage. For the overlap issue, I have fixed in my master branch code, and will publish in next release ASAP. And for the performance issue, I have created a new issue #59 to track, and I will investigate how to improve the render performance, and will update status in that thread, and will notify you too. So I'd like to close this issue now.

@Huachao Huachao closed this as completed Jan 9, 2017
@Huachao Huachao added the bug label Jan 10, 2017
@sfertman
Copy link
Author

@Huachao, thanks for a great extension!

@Huachao
Copy link
Owner

Huachao commented Jan 15, 2017

@sfertman the bug has been fixed in latest version 0.12.0, you can have a try and verify it. 😄

@sfertman
Copy link
Author

@Huachao. Verified. Line numbers work now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants