Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken works with certificates #263

Closed
maxtar opened this issue Oct 8, 2018 · 9 comments
Closed

Broken works with certificates #263

maxtar opened this issue Oct 8, 2018 · 9 comments
Labels

Comments

@maxtar
Copy link

maxtar commented Oct 8, 2018

  • VSCode Version: 1.27.2 (system setup)
    • Commit: f46c4c469d6e6d8c46f268d1553c5dc4b475840f
    • Date: 2018-09-12T16:17:45.060Z
    • Electron: 2.0.7
    • Chrome: 61.0.3163.100
    • Node.js: 8.9.3
    • V8: 6.1.534.41
    • Architecture: x64
  • REST Client Version: 0.20.0 (2018/10/8)
  • OS Version: Windows 10.

Steps to Reproduce:

  1. Set settings in "rest-client.certificates" like
 "10.0.0.3": {
            "pfx": "d:\\Документы\\Сертиифкат.pfx",
            "passphrase": "password"
        },
  1. Execute the request like this:
GET https://10.0.0.3/api/v1.0/user/1/state HTTP/1.1
Accept: application/json
  1. Got error Hostname/IP doesn't match certificate's altnames: "IP: 10.0.0.3 is not in the cert's list: "

If instead of IP in rest-client.certificates set hostname, after execute appearing the following error message: unable to get local issuer certificate.

Before upgrading to 0.20.0 (2018/10/8) version all have working ok,

@Huachao
Copy link
Owner

Huachao commented Oct 8, 2018

@maxtar nice catch, I will prepare a hot fix tomorrow, sorry for the inconvenience.

@maxtar
Copy link
Author

maxtar commented Oct 8, 2018

@Huachao thanx, this is critical for us. :)

@Huachao
Copy link
Owner

Huachao commented Oct 8, 2018

Before that, you may have to download the previous versions on https://github.com/Huachao/vscode-restclient/releases page.

@maxtar
Copy link
Author

maxtar commented Oct 8, 2018

@Huachao Thank you!

@d-akara
Copy link
Contributor

d-akara commented Oct 8, 2018

@Huachao FYI, This may be the same problem. I'm not using any certificates file and I can't make any request as I get an error "certificate expired".

@Huachao
Copy link
Owner

Huachao commented Oct 8, 2018

Should be same root cause. @dakaraphi is the website you test a public one or a private one? If public, could you share me the request URL?

@Huachao Huachao added the bug label Oct 8, 2018
Huachao added a commit that referenced this issue Oct 8, 2018
@Huachao
Copy link
Owner

Huachao commented Oct 9, 2018

@maxtar @dakaraphi you can try the latest version 0.20.1 to verify. Thanks

@Huachao Huachao closed this as completed Oct 9, 2018
@d-akara
Copy link
Contributor

d-akara commented Oct 9, 2018

@Huachao it is fixed for me. thx!

@maxtar
Copy link
Author

maxtar commented Oct 9, 2018

@Huachao me too. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants