Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove feature requirement for thiscall #34

Merged
merged 5 commits into from
Oct 15, 2023
Merged

fix: remove feature requirement for thiscall #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c5d39d
fix: remove feature requirement for thiscall
ElonGaties Aug 16, 2023
979a75b
fix: remove feature attribute definition
ElonGaties Aug 18, 2023
84b4a1e
Merge branch 'master' into master
Hpmason Oct 15, 2023
fbcf30a
Keep thiscall-abi feature gate for back compat
Hpmason Oct 15, 2023
183b6d5
Update docs for required thiscall-abi version
Hpmason Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ nightly compiler will always target the newest version.

Feature versions:
- `static-detour`: nightly
- `thiscall-abi`: nightly (will be [stabilized in 1.73.0](https://releases.rs/docs/1.73.0/))

- `thiscall-abi`: 1.73.0 or newer

## Example

Expand Down
7 changes: 1 addition & 6 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
all(feature = "static-detour", test),
feature(naked_functions)
)]
#![cfg_attr(
feature = "thiscall-abi",
feature(abi_thiscall)
)]

//! A cross-platform detour library written in Rust.
//!
Expand Down Expand Up @@ -59,8 +55,7 @@
//! - **static-detour**: Required for static detours, due to usage
//! of *unboxed_closures* and *tuple_trait*. The feature also enables a more
//! extensive test suite. *Requires nightly compiler*
//! - **thiscall-abi**: Required for hooking functions that use the "thiscall" ABI, which is
//! nightly only. *Requires nightly compiler*
//! - **thiscall-abi**: Required for hooking functions that use the "thiscall" ABI. *Requires 1.73.0 or greater*
//!
//! ## Platforms
//!
Expand Down
Loading