Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove feature requirement for thiscall #34

Merged
merged 5 commits into from
Oct 15, 2023

Conversation

ElonGaties
Copy link

abi_thiscall is now considered stable by rust
rust-lang/rust@06daa9e

abi_thiscall is now considered stable by rust
rust-lang/rust@06daa9e
@Hpmason
Copy link
Owner

Hpmason commented Aug 17, 2023

Thanks for helping update this with the recent stabilization!

Though it's stabilized, it's not planned to be released until 1.73.0 on October 5th. So until the official toolchain release, I'd like to keep that under the feature flag, that way current users on stable can still compile.

In order to fix the issue with the nightly feature, the lib.rs file is what actually needs to be changed to remove the cfg_attr for thiscall-abi flag here:

https://github.com/Hpmason/retour-rs/blob/master/src/lib.rs#L11-L14

@ElonGaties
Copy link
Author

I have removed that definition, perhaps once thiscall abi can be used on stable this could be pushed.

src/macros.rs Outdated Show resolved Hide resolved
@Hpmason Hpmason merged commit 3bf7863 into Hpmason:master Oct 15, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants