Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve StatementsDao efficiency for reading #613

Open
carlgieringer opened this issue Nov 6, 2023 · 0 comments
Open

Improve StatementsDao efficiency for reading #613

carlgieringer opened this issue Nov 6, 2023 · 0 comments
Labels
performance Server or client resource usage

Comments

@carlgieringer
Copy link
Contributor

carlgieringer commented Nov 6, 2023

Right now StatementsDao.readStatementForId reads the Statements one-by-one using readStatementWithoutSentenceForId (which uses readStatementsWithoutSentencesForIds for a single statement.) We should be able to use some combination of (or a new method that combines the approaches within) readStatementsWithoutSentencesForIds and readStatementChainForId to query the DB just once to get every thing we need for readStatementForId.

But since this may be early optimizing, consider the cost of improving (maybe start monitoring query performance first? #614)

@carlgieringer carlgieringer added the performance Server or client resource usage label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Server or client resource usage
Projects
None yet
Development

No branches or pull requests

1 participant