Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for operationName request field #832

Closed
trmcnvn opened this issue Jan 18, 2023 · 1 comment · Fixed by #834 or #871
Closed

Support for operationName request field #832

trmcnvn opened this issue Jan 18, 2023 · 1 comment · Fixed by #834 or #871
Labels
Enhancement A new feature or improvement to Houdini's public API

Comments

@trmcnvn
Copy link

trmcnvn commented Jan 18, 2023

Describe the feature

Would like to be able to pass operationName to our server. While this field isn't required in a standard setup, it's great for logging & tracing requests on the backend.

Doesn't seem to be a way currently to get the name of the operation within the fetch handler as only the raw text and hash are passed down.

Quick look seems it would be as simple as passing the artifact name down to the fetch handler here:

const result = await client.sendRequest<_Data>(context, {
text: artifact.raw,
hash: artifact.hash,
variables,
})

Won't be able to open a PR until the weekend, so opening this issue until then in case someone wants to take it.

Criticality

nice to have

@AlecAivazis
Copy link
Collaborator

hey @trmcnvn! Thanks for opening this. This is a perfect use case for #365 so I think your best off waiting a bit for that to be ready. It's my top priority right now and I'm trying to have something you can play with by the end of the weekend. At least now there's some social pressure to make sure I hit my internal deadline 😅

@AlecAivazis AlecAivazis mentioned this issue Jan 19, 2023
5 tasks
@AlecAivazis AlecAivazis linked a pull request Jan 20, 2023 that will close this issue
5 tasks
@AlecAivazis AlecAivazis added the Enhancement A new feature or improvement to Houdini's public API label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A new feature or improvement to Houdini's public API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants