Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update deprecated #1361

Closed
wants to merge 5 commits into from
Closed

deps: update deprecated #1361

wants to merge 5 commits into from

Conversation

rgon
Copy link

@rgon rgon commented Sep 14, 2024 •
edited
Loading

Fixes #1360

This PR is to update the glob dependency, which is used both in the build process and in the lib/fs.ts module in the apparently unused glob method.
The library's API has changed, so where its called has been refactored.

This fixes introducing deprecated subdependencies to projects that use houdini.

It also replaces directly deprecated dependencies, installed with this project (but not depending projects).

The build completes successfully. This commit does not affect graphql functionality, only build processes.

Gonzalo Ruiz added 2 commits September 14, 2024 17:19
deps: upgrade glob to v10 due to previous version deprecation. Refact…
607f9e6 
…or callers. Remove @types/glob, since v.>9 already packages in types
fix: reverse the order of listed typedef files, solves typedef compil…
e3ded13 
…ation (@ pnpm typedef) caused by the change in listing order introduced by the new algorithm in glob>9.0.0, see changelog
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 478ddfd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
scripts Patch
houdini Patch
houdini-adapter-auto Patch
houdini-adapter-cloudflare Patch
houdini-adapter-node Patch
houdini-adapter-static Patch
houdini-react Patch
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch
create-houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify Netlify
Copy link

netlify bot commented Sep 14, 2024 •
edited
Loading

✅ Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 478ddfd
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/66e730f48103530008027a75

@netlify Netlify
Copy link

netlify bot commented Sep 14, 2024 •
edited
Loading

✅ Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit 478ddfd
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/66e730f4c802ba0008c6ca2f

rgon
rgon commented Sep 15, 2024
View reviewed changes
packages/_scripts/typedefs.js
(path) => !path.endsWith('.test.ts')
)
).reverse()
Copy link
Author

@rgon rgon Sep 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .reverse() is added because the algorithm change in [email protected] changed the order of walked files.
Adding console.log(files) here shows the change:

With glob v8.1.0 - Generating types for [
houdini-react:typedefs:   './src/plugin/codegen/entries/documentWrappers.ts',
houdini-react:typedefs:   './src/plugin/codegen/entries/fallbacks.ts',
houdini-react:typedefs:   './src/plugin/codegen/entries/index.ts',
houdini-react:typedefs:   './src/plugin/codegen/entries/pages.ts',
houdini-react:typedefs:   './src/plugin/codegen/index.ts',
houdini-react:typedefs:   './src/plugin/codegen/manifest.ts',
houdini-react:typedefs:   './src/plugin/codegen/render.ts',
houdini-react:typedefs:   './src/plugin/codegen/router.ts',
houdini-react:typedefs:   './src/plugin/codegen/typeRoot.ts',
houdini-react:typedefs:   './src/plugin/config.ts',
houdini-react:typedefs:   './src/plugin/dedent.ts',
houdini-react:typedefs:   './src/plugin/extract.ts',
houdini-react:typedefs:   './src/plugin/index.ts',
houdini-react:typedefs:   './src/plugin/transform.ts',
houdini-react:typedefs:   './src/plugin/vite.tsx',
houdini-react:typedefs:   './src/runtime/client.ts',
houdini-react:typedefs:   './src/runtime/clientPlugin.ts',
houdini-react:typedefs:   './src/runtime/componentFields.ts',
houdini-react:typedefs:   './src/runtime/hooks/index.ts',
houdini-react:typedefs:   './src/runtime/hooks/useDeepCompareEffect.ts',
houdini-react:typedefs:   './src/runtime/hooks/useDocumentHandle.ts',
houdini-react:typedefs:   './src/runtime/hooks/useDocumentStore.ts',
houdini-react:typedefs:   './src/runtime/hooks/useDocumentSubscription.ts',
houdini-react:typedefs:   './src/runtime/hooks/useFragment.ts',
houdini-react:typedefs:   './src/runtime/hooks/useFragmentHandle.ts',
houdini-react:typedefs:   './src/runtime/hooks/useIsMounted.ts',
houdini-react:typedefs:   './src/runtime/hooks/useMutation.ts',
houdini-react:typedefs:   './src/runtime/hooks/useQuery.ts',
houdini-react:typedefs:   './src/runtime/hooks/useQueryHandle.ts',
houdini-react:typedefs:   './src/runtime/hooks/useSubscription.ts',
houdini-react:typedefs:   './src/runtime/hooks/useSubscriptionHandle.ts',
houdini-react:typedefs:   './src/runtime/index.tsx',
houdini-react:typedefs:   './src/runtime/manifest.ts',
houdini-react:typedefs:   './src/runtime/routing/cache.ts',
houdini-react:typedefs:   './src/runtime/routing/index.ts',
houdini-react:typedefs:   './src/runtime/routing/Router.tsx',
houdini-react:typedefs:   './src/server/index.ts'
houdini-react:typedefs: ]

New order after glob change:

With glob v10.4.5 houdini-react:typedefs: Generating types for [
    houdini-react:typedefs:   'src/server/index.ts',
    houdini-react:typedefs:   'src/runtime/manifest.ts',
    houdini-react:typedefs:   'src/runtime/index.tsx',
    houdini-react:typedefs:   'src/runtime/componentFields.ts',
    houdini-react:typedefs:   'src/runtime/clientPlugin.ts',
    houdini-react:typedefs:   'src/runtime/client.ts',
    houdini-react:typedefs:   'src/plugin/vite.tsx',
    houdini-react:typedefs:   'src/plugin/transform.ts',
    houdini-react:typedefs:   'src/plugin/index.ts',
    houdini-react:typedefs:   'src/plugin/extract.ts',
    houdini-react:typedefs:   'src/plugin/dedent.ts',
    houdini-react:typedefs:   'src/plugin/config.ts',
    houdini-react:typedefs:   'src/runtime/routing/index.ts',
    houdini-react:typedefs:   'src/runtime/routing/cache.ts',
    houdini-react:typedefs:   'src/runtime/routing/Router.tsx',
    houdini-react:typedefs:   'src/runtime/hooks/useSubscriptionHandle.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useSubscription.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useQueryHandle.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useQuery.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useMutation.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useIsMounted.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useFragmentHandle.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useFragment.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useDocumentSubscription.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useDocumentStore.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useDocumentHandle.ts',
    houdini-react:typedefs:   'src/runtime/hooks/useDeepCompareEffect.ts',
    houdini-react:typedefs:   'src/runtime/hooks/index.ts',
    houdini-react:typedefs:   'src/plugin/codegen/typeRoot.ts',
    houdini-react:typedefs:   'src/plugin/codegen/router.ts',
    houdini-react:typedefs:   'src/plugin/codegen/render.ts',
    houdini-react:typedefs:   'src/plugin/codegen/manifest.ts',
    houdini-react:typedefs:   'src/plugin/codegen/index.ts',
    houdini-react:typedefs:   'src/plugin/codegen/entries/pages.ts',
    houdini-react:typedefs:   'src/plugin/codegen/entries/index.ts',
    houdini-react:typedefs:   'src/plugin/codegen/entries/fallbacks.ts',
    houdini-react:typedefs:   'src/plugin/codegen/entries/documentWrappers.ts'
    houdini-react:typedefs: ]

Notice that this order change caused houdini-react:typedefs to start with src/server/index.ts, without any other types already generated, causing the following build error:

Build error 
$ pnpm typedefs



[email protected] typedefs /home/rgon/Downloads/houdini

turbo run typedefs --filter="./packages/*"




• Packages in scope: create-houdini, houdini, houdini-adapter-auto, houdini-adapter-cloudflare, houdini-adapter-node, houdini-adapter-static, houdini-plugin-svelte-global-stores, houdini-react, houdini-svelte, scripts

• Running typedefs in 10 packages

• Remote caching disabled

houdini:typedefs: cache miss, executing 9e9eeb377aa52de5

houdini:compile: cache miss, executing 84307d3ac110cfcd

houdini:compile:

houdini:compile: > [email protected] compile /home/rgon/Downloads/houdini/packages/houdini

houdini:compile: > scripts build

houdini:compile:

houdini:typedefs:

houdini:typedefs: > [email protected] typedefs /home/rgon/Downloads/houdini/packages/houdini

houdini:typedefs: > scripts typedefs

houdini:typedefs:

houdini:typedefs: Generating types for [

houdini:typedefs:   'src/vite/schema.ts',

houdini:typedefs:   'src/vite/index.ts',

houdini:typedefs:   'src/vite/imports.ts',

houdini:typedefs:   'src/vite/houdini.ts',

houdini:typedefs:   'src/vite/ast.ts',

houdini:typedefs:   'src/test/index.ts',

houdini:typedefs:   'src/runtime/index.ts',

houdini:typedefs:   'src/runtime/generated.ts',

houdini:typedefs:   'src/lib/walk.ts',

houdini:typedefs:   'src/lib/typescript.ts',

houdini:typedefs:   'src/lib/types.ts',

houdini:typedefs:   'src/lib/plugin.ts',

houdini:typedefs:   'src/lib/pipeline.ts',

houdini:typedefs:   'src/lib/path.ts',

houdini:typedefs:   'src/lib/parse.ts',

houdini:typedefs:   'src/lib/introspection.ts',

houdini:typedefs:   'src/lib/index.ts',

houdini:typedefs:   'src/lib/imports.ts',

houdini:typedefs:   'src/lib/graphql.ts',

houdini:typedefs:   'src/lib/fs.ts',

houdini:typedefs:   'src/lib/error.ts',

houdini:typedefs:   'src/lib/detectTools.ts',

houdini:typedefs:   'src/lib/deepMerge.ts',

houdini:typedefs:   'src/lib/constants.ts',

houdini:typedefs:   'src/lib/config.ts',

houdini:typedefs:   'src/lib/cleanupFiles.ts',

houdini:typedefs:   'src/cmd/pullSchema.ts',

houdini:typedefs:   'src/cmd/init.ts',

houdini:typedefs:   'src/cmd/index.ts',

houdini:typedefs:   'src/cmd/generate.ts',

houdini:typedefs:   'src/codegen/index.ts',

houdini:typedefs:   'src/adapter/index.tsx',

houdini:typedefs:   'src/runtime/router/types.ts',

houdini:typedefs:   'src/runtime/router/session.ts',

houdini:typedefs:   'src/runtime/router/server.ts',

houdini:typedefs:   'src/runtime/router/match.ts',

houdini:typedefs:   'src/runtime/router/jwt.ts',

houdini:typedefs:   'src/runtime/router/cookies.ts',

houdini:typedefs:   'src/runtime/public/types.ts',

houdini:typedefs:   'src/runtime/public/record.ts',

houdini:typedefs:   'src/runtime/public/list.ts',

houdini:typedefs:   'src/runtime/public/index.ts',

houdini:typedefs:   'src/runtime/public/cache.ts',

houdini:typedefs:   'src/runtime/lib/types.ts',

houdini:typedefs:   'src/runtime/lib/store.ts',

houdini:typedefs:   'src/runtime/lib/selection.ts',

houdini:typedefs:   'src/runtime/lib/scalars.ts',

houdini:typedefs:   'src/runtime/lib/pagination.ts',

houdini:typedefs:   'src/runtime/lib/pageInfo.ts',

houdini:typedefs:   'src/runtime/lib/lru.ts',

houdini:typedefs:   'src/runtime/lib/log.ts',

houdini:typedefs:   'src/runtime/lib/key.ts',

houdini:typedefs:   'src/runtime/lib/index.ts',

houdini:typedefs:   'src/runtime/lib/flatten.ts',

houdini:typedefs:   'src/runtime/lib/deepEquals.ts',

houdini:typedefs:   'src/runtime/lib/constants.ts',

houdini:typedefs:   'src/runtime/lib/config.ts',

houdini:typedefs:   'src/runtime/imports/pluginConfig.ts',

houdini:typedefs:   'src/runtime/imports/config.ts',

houdini:typedefs:   'src/runtime/client/index.ts',

houdini:typedefs:   'src/runtime/client/documentStore.ts',

houdini:typedefs:   'src/runtime/cache/subscription.ts',

houdini:typedefs:   'src/runtime/cache/stuff.ts',

houdini:typedefs:   'src/runtime/cache/storage.ts',

houdini:typedefs:   'src/runtime/cache/staleManager.ts',

houdini:typedefs:   'src/runtime/cache/lists.ts',

houdini:typedefs:   'src/runtime/cache/index.ts',

houdini:typedefs:   'src/runtime/cache/gc.ts',

houdini:typedefs:   'src/runtime/cache/constants.ts',

houdini:typedefs:   'src/runtime/cache/cache.ts',

houdini:typedefs:   'src/lib/router/types.ts',

houdini:typedefs:   'src/lib/router/server.ts',

houdini:typedefs:   'src/lib/router/manifest.ts',

houdini:typedefs:   'src/lib/router/index.ts',

houdini:typedefs:   'src/lib/router/conventions.ts',

houdini:typedefs:   'src/codegen/validators/uniqueNames.ts',

houdini:typedefs:   'src/codegen/validators/typeCheck.ts',

houdini:typedefs:   'src/codegen/validators/plugins.ts',

houdini:typedefs:   'src/codegen/validators/noIDAlias.ts',

houdini:typedefs:   'src/codegen/validators/index.ts',

houdini:typedefs:   'src/codegen/validators/componentFields.ts',

houdini:typedefs:   'src/codegen/utils/stripLoc.ts',

houdini:typedefs:   'src/codegen/utils/objectIdentificationSelection.ts',

houdini:typedefs:   'src/codegen/utils/murmur.ts',

houdini:typedefs:   'src/codegen/utils/moduleExport.ts',

houdini:typedefs:   'src/codegen/utils/index.ts',

houdini:typedefs:   'src/codegen/utils/flattenSelections.ts',

houdini:typedefs:   'src/codegen/utils/commonjs.ts',

houdini:typedefs:   'src/codegen/transforms/typename.ts',

houdini:typedefs:   'src/codegen/transforms/schema.ts',

houdini:typedefs:   'src/codegen/transforms/runtimeScalars.ts',

houdini:typedefs:   'src/codegen/transforms/paginate.ts',

houdini:typedefs:   'src/codegen/transforms/list.ts',

houdini:typedefs:   'src/codegen/transforms/index.ts',

houdini:typedefs:   'src/codegen/transforms/fragmentVariables.ts',

houdini:typedefs:   'src/codegen/transforms/componentFields.ts',

houdini:typedefs:   'src/codegen/transforms/collectDefinitions.ts',

houdini:typedefs:   'src/codegen/transforms/addID.ts',

houdini:typedefs:   'src/codegen/generators/index.ts',

houdini:typedefs:   'src/runtime/public/tests/test.ts',

houdini:typedefs:   ... 38 more items

houdini:typedefs: ]

houdini-svelte:compile: cache miss, executing 3bbd8efe96d79de3

houdini-svelte:compile:

houdini-svelte:compile: > [email protected] compile /home/rgon/Downloads/houdini/packages/houdini-svelte

houdini-svelte:compile: > scripts build --plugin

houdini-svelte:compile:

houdini-svelte:typedefs: cache miss, executing 8517670b97231da9

houdini-react:typedefs: cache miss, executing e98ca8e4f323a0be

houdini-svelte:typedefs:

houdini-svelte:typedefs: > [email protected] typedefs /home/rgon/Downloads/houdini/packages/houdini-svelte

houdini-svelte:typedefs: > scripts typedefs --plugin

houdini-svelte:typedefs:

houdini-react:typedefs:

houdini-react:typedefs: > [email protected] typedefs /home/rgon/Downloads/houdini/packages/houdini-react

houdini-react:typedefs: > scripts typedefs --plugin

houdini-react:typedefs:

houdini-svelte:typedefs: Generating types for [

houdini-svelte:typedefs:   'src/test/index.ts',

houdini-svelte:typedefs:   'src/preprocess/index.ts',

houdini-svelte:typedefs:   'src/runtime/types.ts',

houdini-svelte:typedefs:   'src/runtime/session.ts',

houdini-svelte:typedefs:   'src/runtime/index.ts',

houdini-svelte:typedefs:   'src/runtime/fragments.ts',

houdini-svelte:typedefs:   'src/runtime/client.ts',

houdini-svelte:typedefs:   'src/runtime/adapter.ts',

houdini-svelte:typedefs:   'src/plugin/validate.ts',

houdini-svelte:typedefs:   'src/plugin/routing.ts',

houdini-svelte:typedefs:   'src/plugin/naming.ts',

houdini-svelte:typedefs:   'src/plugin/kit.ts',

houdini-svelte:typedefs:   'src/plugin/index.ts',

houdini-svelte:typedefs:   'src/plugin/fsPatch.ts',

houdini-svelte:typedefs:   'src/plugin/extractLoadFunction.ts',

houdini-svelte:typedefs:   'src/plugin/extract.ts',

houdini-svelte:typedefs:   'src/plugin/artifactData.ts',

houdini-svelte:typedefs:   'src/runtime/stores/subscription.ts',

houdini-svelte:typedefs:   'src/runtime/stores/query.ts',

houdini-svelte:typedefs:   'src/runtime/stores/mutation.ts',

houdini-svelte:typedefs:   'src/runtime/stores/index.ts',

houdini-svelte:typedefs:   'src/runtime/stores/fragment.ts',

houdini-svelte:typedefs:   'src/runtime/stores/base.ts',

houdini-svelte:typedefs:   'src/plugin/transforms/types.ts',

houdini-svelte:typedefs:   'src/plugin/transforms/tags.ts',

houdini-svelte:typedefs:   'src/plugin/transforms/index.ts',

houdini-svelte:typedefs:   'src/plugin/transforms/componentQuery.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/index.ts',

houdini-svelte:typedefs:   'src/runtime/stores/pagination/query.ts',

houdini-svelte:typedefs:   'src/runtime/stores/pagination/index.ts',

houdini-svelte:typedefs:   'src/runtime/stores/pagination/fragment.ts',

houdini-svelte:typedefs:   'src/plugin/transforms/kit/session.ts',

houdini-svelte:typedefs:   'src/plugin/transforms/kit/load.ts',

houdini-svelte:typedefs:   'src/plugin/transforms/kit/init.ts',

houdini-svelte:typedefs:   'src/plugin/transforms/kit/index.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/stores/subscription.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/stores/query.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/stores/mutation.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/stores/index.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/stores/fragment.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/stores/custom.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/routes/index.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/fragmentTypedefs/index.ts',

houdini-svelte:typedefs:   'src/plugin/codegen/components/index.ts'

houdini-svelte:typedefs: ]

houdini-react:typedefs: Generating types for [

houdini-react:typedefs:   'src/server/index.ts',

houdini-react:typedefs:   'src/runtime/manifest.ts',

houdini-react:typedefs:   'src/runtime/index.tsx',

houdini-react:typedefs:   'src/runtime/componentFields.ts',

houdini-react:typedefs:   'src/runtime/clientPlugin.ts',

houdini-react:typedefs:   'src/runtime/client.ts',

houdini-react:typedefs:   'src/plugin/vite.tsx',

houdini-react:typedefs:   'src/plugin/transform.ts',

houdini-react:typedefs:   'src/plugin/index.ts',

houdini-react:typedefs:   'src/plugin/extract.ts',

houdini-react:typedefs:   'src/plugin/dedent.ts',

houdini-react:typedefs:   'src/plugin/config.ts',

houdini-react:typedefs:   'src/runtime/routing/index.ts',

houdini-react:typedefs:   'src/runtime/routing/cache.ts',

houdini-react:typedefs:   'src/runtime/routing/Router.tsx',

houdini-react:typedefs:   'src/runtime/hooks/useSubscriptionHandle.ts',

houdini-react:typedefs:   'src/runtime/hooks/useSubscription.ts',

houdini-react:typedefs:   'src/runtime/hooks/useQueryHandle.ts',

houdini-react:typedefs:   'src/runtime/hooks/useQuery.ts',

houdini-react:typedefs:   'src/runtime/hooks/useMutation.ts',

houdini-react:typedefs:   'src/runtime/hooks/useIsMounted.ts',

houdini-react:typedefs:   'src/runtime/hooks/useFragmentHandle.ts',

houdini-react:typedefs:   'src/runtime/hooks/useFragment.ts',

houdini-react:typedefs:   'src/runtime/hooks/useDocumentSubscription.ts',

houdini-react:typedefs:   'src/runtime/hooks/useDocumentStore.ts',

houdini-react:typedefs:   'src/runtime/hooks/useDocumentHandle.ts',

houdini-react:typedefs:   'src/runtime/hooks/useDeepCompareEffect.ts',

houdini-react:typedefs:   'src/runtime/hooks/index.ts',

houdini-react:typedefs:   'src/plugin/codegen/typeRoot.ts',

houdini-react:typedefs:   'src/plugin/codegen/router.ts',

houdini-react:typedefs:   'src/plugin/codegen/render.ts',

houdini-react:typedefs:   'src/plugin/codegen/manifest.ts',

houdini-react:typedefs:   'src/plugin/codegen/index.ts',

houdini-react:typedefs:   'src/plugin/codegen/entries/pages.ts',

houdini-react:typedefs:   'src/plugin/codegen/entries/index.ts',

houdini-react:typedefs:   'src/plugin/codegen/entries/fallbacks.ts',

houdini-react:typedefs:   'src/plugin/codegen/entries/documentWrappers.ts'

houdini-react:typedefs: ]

houdini-plugin-svelte-global-stores:typedefs: cache miss, executing af7d67e88a56ea6e

houdini-plugin-svelte-global-stores:typedefs:

houdini-plugin-svelte-global-stores:typedefs: > [email protected] typedefs /home/rgon/Downloads/houdini/packages/plugin-svelte-global-stores

houdini-plugin-svelte-global-stores:typedefs: > scripts typedefs --plugin

houdini-plugin-svelte-global-stores:typedefs:

houdini-plugin-svelte-global-stores:typedefs: Generating types for [

houdini-plugin-svelte-global-stores:typedefs:   'src/test/index.ts',

houdini-plugin-svelte-global-stores:typedefs:   'src/plugin/kit.ts',

houdini-plugin-svelte-global-stores:typedefs:   'src/plugin/index.ts',

houdini-plugin-svelte-global-stores:typedefs:   'src/plugin/codegen/index.ts',

houdini-plugin-svelte-global-stores:typedefs:   'src/plugin/codegen/stores/subscription.ts',

houdini-plugin-svelte-global-stores:typedefs:   'src/plugin/codegen/stores/query.ts',

houdini-plugin-svelte-global-stores:typedefs:   'src/plugin/codegen/stores/mutation.ts',

houdini-plugin-svelte-global-stores:typedefs:   'src/plugin/codegen/stores/index.ts',

houdini-plugin-svelte-global-stores:typedefs:   'src/plugin/codegen/stores/fragment.ts'

houdini-plugin-svelte-global-stores:typedefs: ]

houdini-react:typedefs: src/runtime/index.tsx (41,4): Type 'Element' is not assignable to type 'ReactNode'.

houdini-react:typedefs: /home/rgon/Downloads/houdini/packages/houdini-react/src/runtime/routing/Router.tsx (141,4): Type 'Element' is not assignable to type 'ReactNode'.

houdini-react:typedefs:   Property 'children' is missing in type 'Element' but required in type 'ReactPortal'.

houdini-react:typedefs: /home/rgon/Downloads/houdini/packages/houdini-react/src/runtime/routing/Router.tsx (148,5): Type 'Element' is not assignable to type 'ReactNode'.

houdini-react:typedefs:  ELIFECYCLE  Command failed with exit code 1.

houdini-react:typedefs: ERROR: command finished with error: command (/home/rgon/Downloads/houdini/packages/houdini-react) pnpm run typedefs exited (1)

command (/home/rgon/Downloads/houdini/packages/houdini-react) pnpm run typedefs exited (1)


Tasks:    4 successful, 6 total

Cached:    0 cached, 6 total

Time:    21.799s


ERROR  run failed: command  exited (1)

 ELIFECYCLE  Command failed with exit code 1.

Reversing this order solved the typedef generation.

@rgon rgon changed the title Deps update deprecated deps: update deprecated Sep 15, 2024
@rgon
Copy link
Author

rgon commented Sep 16, 2024 •
edited
Loading

I updated this PR to fix also some internal deprecated dependencies.

Not all of them, however, since updating the rest of old dependencies require upgrading: vite 5, svelte 4, sveltekit, typescript 5, prettier 3 and a few others, which will probably have side effects.

@SeppahBaws
Copy link
Collaborator

I think we'll leave upgrading the dependencies for the Houdini 2.0 release.
I have tried upgrading to Svelte 4 before, but got stuck on some peer dependencies that I wasn't able to fix. Since Houdini 2.0 will also upgrade to Svelte 5, I figure it's not too big of a deal to leave Svelte on v3 for now...

@rgon
Copy link
Author

rgon commented Sep 17, 2024 •
edited
Loading

@SeppahBaws Then, I don't mind you closing this PR. Should I open a separate one to track the WIP of Svelte 4, TS5 & larger updates (I have made an attempt at rgon:deps-upgrade-ts5)? Upgrading to Svelte 5 will require all of these build-process changes anyways, which are quite a bit of effort. Other than that, Svelte 4 should not break anything else, and should be a smart middle ground not to break everything at once.

I seem to have fixed those peer dependency issues, but am having trouble with the DTS build.

Edit: nevermind, I didn't see the Svelte 5 PR. Closing in favor of it.

@rgon rgon closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix deprecated dependencies
2 participants
@rgon @SeppahBaws