Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteKit 2 support #1241

Closed
eikaramba opened this issue Dec 15, 2023 · 5 comments
Closed

SvelteKit 2 support #1241

eikaramba opened this issue Dec 15, 2023 · 5 comments

Comments

@eikaramba
Copy link
Contributor

eikaramba commented Dec 15, 2023

Describe the feature

SvelteKit 2 was released - error handling has changed and is the biggest breaking change for this library i guess.

Criticality

waiting for it before migrating to sveltekit 2

@jycouet
Copy link
Contributor

jycouet commented Dec 15, 2023

I think there is also something with the load & await 🤔
Do you already have a repro? or?

@eikaramba
Copy link
Contributor Author

i just tested a private project of mine. interestingly houdini works there although i updated to sveltekit 2.0 - i haven't tested every case, but was suprised that no error was shown or something like that.

@jycouet
Copy link
Contributor

jycouet commented Dec 18, 2023

I confirm that everything is working as expected with "@sveltejs/kit": "^2.0.0"

e2e tests running on kit 👇
Capture d’écran 2023-12-18 à 19 44 10

I'll do a PR to bump e2e tests, but I guess we can close this "issue"?

@eikaramba
Copy link
Contributor Author

yes this can be closed, sry i really thought that more would be needed. unfortunately i wasn't able to run the code at the time to verify my claim :)

@xmlking
Copy link

xmlking commented Dec 23, 2023

@jycouet find following issue, when I created fresh project today. looks like vite plugin order of execution issue!
#1246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants