From cd00b5f436412ecc3ac2225d2ee8a9201b172da0 Mon Sep 17 00:00:00 2001
From: Alec Aivazis <alec@aivazis.com>
Date: Sat, 17 Sep 2022 09:29:40 -0700
Subject: [PATCH] Fix error when unsubscribing from cache between fetch and
 render (#548)

* test to reproduce reported error

* subscribing to the store should always subscribe to the cache

* integration tests pass

* changeset
---
 .changeset/tidy-foxes-melt.md                 |  5 +++++
 .../stores/mutation-update/+page.svelte       | 19 ++++++++-----------
 .../routes/stores/mutation-update/+page.ts    | 18 ++++++++++++++++++
 src/runtime/stores/query.ts                   |  5 +++++
 4 files changed, 36 insertions(+), 11 deletions(-)
 create mode 100644 .changeset/tidy-foxes-melt.md
 create mode 100644 integration/src/routes/stores/mutation-update/+page.ts

diff --git a/.changeset/tidy-foxes-melt.md b/.changeset/tidy-foxes-melt.md
new file mode 100644
index 0000000000..5261d330d7
--- /dev/null
+++ b/.changeset/tidy-foxes-melt.md
@@ -0,0 +1,5 @@
+---
+'houdini': patch
+---
+
+Fix bug when unsubscribing between load and render
diff --git a/integration/src/routes/stores/mutation-update/+page.svelte b/integration/src/routes/stores/mutation-update/+page.svelte
index 97e82d3dc8..d71a870f21 100644
--- a/integration/src/routes/stores/mutation-update/+page.svelte
+++ b/integration/src/routes/stores/mutation-update/+page.svelte
@@ -1,16 +1,13 @@
 <script lang="ts">
-  import { GQL_UpdateUser, graphql, MutationUpdateUsersListStore } from '$houdini';
+  import { GQL_UpdateUser, graphql } from '$houdini';
   import { stry } from '@kitql/helper';
+  import type { PageData } from './$types';
 
-  const usersList: MutationUpdateUsersListStore = graphql`
-    query MutationUpdateUsersList {
-      usersList(limit: 5, snapshot: "update-user-mutation") {
-        id
-        name
-        ...UserInfo
-      }
-    }
-  `;
+  export let data: PageData;
+
+  // leave this awkward pattern to make sure this doesn't come back: https://github.com/HoudiniGraphql/houdini/issues/543
+  let { TestMutationUpdateUsersList } = data;
+  $: ({ TestMutationUpdateUsersList } = data);
 
   async function update() {
     await GQL_UpdateUser.mutate({
@@ -32,7 +29,7 @@
 <button id="revert" on:click={revert}>Reset User</button>
 
 <ul>
-  {#each $usersList.data?.usersList ?? [] as user}
+  {#each $TestMutationUpdateUsersList.data?.usersList ?? [] as user}
     <li>
       {user.id} - {user.name}
     </li>
diff --git a/integration/src/routes/stores/mutation-update/+page.ts b/integration/src/routes/stores/mutation-update/+page.ts
new file mode 100644
index 0000000000..bcff404d98
--- /dev/null
+++ b/integration/src/routes/stores/mutation-update/+page.ts
@@ -0,0 +1,18 @@
+import { graphql, load_TestMutationUpdateUsersList } from '$houdini';
+import type { LoadEvent } from '@sveltejs/kit';
+
+export async function load(event: LoadEvent) {
+  return {
+    ...(await load_TestMutationUpdateUsersList({ event }))
+  };
+}
+
+graphql`
+  query TestMutationUpdateUsersList {
+    usersList(limit: 5, snapshot: "update-user-mutation") {
+      id
+      name
+      ...UserInfo
+    }
+  }
+`;
diff --git a/src/runtime/stores/query.ts b/src/runtime/stores/query.ts
index 81908ac72c..9113f384af 100644
--- a/src/runtime/stores/query.ts
+++ b/src/runtime/stores/query.ts
@@ -166,6 +166,11 @@ If this is leftovers from old versions of houdini, you can safely remove this \`
 		// we have a new subscriber
 		this.subscriberCount = (this.subscriberCount ?? 0) + 1
 
+		// make sure that the store is always listening to the cache (on the browser)
+		if (isBrowser && !this.subscriptionSpec) {
+			this.refreshSubscription(this.lastVariables ?? ({} as _Input))
+		}
+
 		// Handle unsubscribe
 		return () => {
 			// we lost a subscriber