Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Build acceptance test for visits.index #704

Closed
billybonks opened this issue Oct 2, 2016 · 6 comments
Closed

Build acceptance test for visits.index #704

billybonks opened this issue Oct 2, 2016 · 6 comments

Comments

@billybonks
Copy link
Contributor

In order to effectively use the no missing translations test, we need to make sure that every page is visited during acceptance tests.

This issue tracks the missing visits.index acceptance test

for ember new commers the value some.route is the route that's missing you can find them under router.js

@billybonks
Copy link
Contributor Author

@jkleinsc i think this route is never visited so we can close this ?

@jkleinsc
Copy link
Member

@billybonks yes... though should we remove it from router.js in order to make sure your testing for untested routes works?

@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Mar 14, 2017
@WilliamJefferies
Copy link

@jkleinsc I will work on this

@billybonks
Copy link
Contributor Author

👍

@wildaces215
Copy link

I want to work on this as well!

@stale
Copy link

stale bot commented Aug 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix indicates an issue/pull request will not be worked on label Aug 7, 2019
@fox1t fox1t removed the help wanted indicates that an issue is open for contributions label Aug 7, 2019
@fox1t fox1t closed this as completed Aug 7, 2019
@stale stale bot removed the wontfix indicates an issue/pull request will not be worked on label Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants