Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

System wide currency configuration #678

Closed
taras opened this issue Sep 27, 2016 · 3 comments
Closed

System wide currency configuration #678

taras opened this issue Sep 27, 2016 · 3 comments

Comments

@taras
Copy link
Contributor

taras commented Sep 27, 2016

Expected behavior:
We need to have a standard way to manage currency formatting for the entire application. We just merged #668 which provide a number field that we can use to allow users to input numbers. We could wire a new service into that input field to ensure that input values are sanitized correctly.

Actual behavior:
All locals are using $ as currency symbol.

Let's hash out all of the requirements around this service and everything that'll need to be implemented to make it happen.

Questions:

  1. What library can we use to provide output formatting and input sanitization?
  2. How do we wire this into existing localization?
  3. How do we find all of the currency fields?

/cc @jkleinsc @wolfieorama

@ghost
Copy link

ghost commented Oct 2, 2016

Does this not intersect (replace?) #314?

@jkleinsc
Copy link
Member

jkleinsc commented Oct 3, 2016

@BogdanAlexandru you are correct. This is duplicate of #314.

@taras @wolfieorama I would like to close this as a duplicate of #314.

@jkleinsc
Copy link
Member

Closing as duplicate of #314

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants