Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Translate bare strings in mixins #548

Closed
3 of 4 tasks
billybonks opened this issue Jul 2, 2016 · 3 comments
Closed
3 of 4 tasks

Translate bare strings in mixins #548

billybonks opened this issue Jul 2, 2016 · 3 comments
Labels
help wanted indicates that an issue is open for contributions localization

Comments

@billybonks
Copy link
Contributor

billybonks commented Jul 2, 2016

The following mixin files have bare strings that need to be translated

  • result-validation.js
  • navigation.js
  • fulfill_request.js
  • dob-days.js
@tangollama tangollama added help wanted indicates that an issue is open for contributions localization labels Aug 6, 2016
@tangollama tangollama added Hack Day help wanted indicates that an issue is open for contributions and removed help wanted indicates that an issue is open for contributions labels Sep 17, 2016
@jkleinsc
Copy link
Member

@billybonks navigation.js automatically translates the strings there in the localizedNavItems function, so it doesn't need to be translated.

@jkleinsc
Copy link
Member

@billybonks in regards to the strings not being propagated to the ui, you are correct - the only place you would see them is in the ember inspector if you were looking at promises you would see the text there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted indicates that an issue is open for contributions localization
Projects
None yet
Development

No branches or pull requests

4 participants