Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(labs): support list of notes for lab requests #2325

Merged
merged 13 commits into from
Sep 15, 2020

Conversation

rsousaj
Copy link
Contributor

@rsousaj rsousaj commented Aug 22, 2020

Fixes #2297 .

Changes proposed in this pull request:

  • Lab's interface notes property as string[]
  • Callout components used to show past notes at ViewLab

@gitpod-io
Copy link

gitpod-io bot commented Aug 22, 2020

@morrme morrme requested a review from jackcmeyer August 24, 2020 02:01
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Aug 30, 2020
@matteovivona matteovivona added this to the v2.0 milestone Aug 30, 2020
src/labs/ViewLab.tsx Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Aug 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/cv540dib6
✅ Preview: https://hospitalrun-fron-git-fork-rsousaj-issue-2297-support-lis-5ba699.hospitalrun.vercel.app

@@ -24,10 +24,12 @@ const NewLabRequest = () => {
const [newLabRequest, setNewLabRequest] = useState({
patient: '',
type: '',
notes: '',
// notes: [''],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it as requested but looks like the deployment failed and I don't really know if it was my fault.

@rsousaj rsousaj requested a review from fox1t September 2, 2020 01:04
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview September 2, 2020 13:56 Inactive
@morrme
Copy link
Contributor

morrme commented Sep 9, 2020

This seems to be affected by HospitalRun/components#583 @rsousaj @jackcmeyer

@morrme
Copy link
Contributor

morrme commented Sep 14, 2020

@tehkapa What is the status of this PR?

@jackcmeyer jackcmeyer merged commit 019a5f8 into HospitalRun:master Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support a list of notes for a lab request
6 participants