feat(imaging): link image with visit

[AlexTan331]

Fixes #2291 .

Changes proposed in this pull request:

• create a dropdown list for visits
• render a list of visits for the selected patient when requesting a new imaging

[gitpod-io]

[blestab]

Just curious why we decide to add Visit here? Aren't we already looking at Visit* fields? if we have to do it for one should we maybe not also do it for all of them? i.e. Visit Start Date, Visit End Date etc for consistency? Also not sure if this is related to the issue that this PR is meant to be addressing? I stand corrected should it be.

[AlexTan331]

What I was originally thinking is to create a translation key for the visit type so that it can be used in the new request imaging page
<div className="visits"> {newImagingRequest.patient && visitOption ? ( <SelectWithLabelFormGroup name="visit" label={t('patient.visits.type')}

Maybe it will make more sense to create a new translation key in the imaging locale index.ts file to prevent some confusion. What do you think?

[blestab]

You can keep the translation key in patients since visits are part of the patients module. Maybe just call it Visit rather than Visit Type because visit type makes me think (outpatient/inpatient/emergency etc) where here we are giving the user a list of all visits for this patient regardless of the type of visit it is, what do you think?

[AlexTan331]

On it

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/8a7sca0e8
✅ Preview: https://hospitalrun-frontend-git-fork-alextan331-link-image-with-visit.hospitalrun.vercel.app

[jackcmeyer]

this should store patient id rather than the patient full name

[AlexTan331]

If this store as patient id, the patient field on the table in requested imagings page would display its patient id instead of full name

[jackcmeyer]

do the visits need to be a state variable? seems like we could just reference patient.visits wherever we use the visits.

[AlexTan331]

I believe we need the visits to be a state variable. Because we can only fetch the visits data inside the onPatientChange method using the patient parameter (as we fetch the patient using this line onSearch={async (query: string) => PatientRepository.search(query)}). Using state variable ensures that the visits data will be re-rendered whenever the patient field value is changed.

[jackcmeyer]

since defaultSelected takes an undefined, I think we can simplify this logic to the following (or something similar to this):

<SelectWithLabelFormGroup
  name="visit"
  label={t('imagings.imaging.visit')}
  isRequired
  isEditable={patient !== undefined}
  options={patient.visits?.map((v) => ({ label: v.type, value: v.id })) || []}
  onChange={(values) => {
 onVisitChange(values[0])
}}
          />

[jackcmeyer]

I think the label should be something like ${visitType} at ${startDateTime}or${visitType} (${startDateTime)}`