Cannot add Imaging Pricing Types manually

[drakemedic]

Expected behavior: Edit Lookup Lists, select Imaging Pricing types, add pricing type

Actual behavior: No option to add a pricing type is available, only file upload.

Steps to reproduce: Select Lookup lists from Admin menu, go to Imaging Pricing Types, try to add new pricing type

Screenshots (if applicable):

OS and Browser: Hospitalrun-server (Ubuntu 16.04) accessed via Linux Mint 18.3 and Firefox 60.0.1

[stukalin]

Hmm.. there was an issue #877 and the commit aa09e64 fixing that. I don't know any more

[MatthewDorner]

yes, it looks like aa09e64 was intended to stop you from deleting default items, but also made it impossible to add items. so I guess we'd need to differentiate between default and non-default items.

Also what browser did you take that screenshot with? Mine has the checkboxes positioned differently different in Chrome and Firefox:

[MatthewDorner]

huh, seems more complicated than I thought. should read #1139 as well.

[drakemedic]

My screenshot was from Firefox.
I don't know whether the Imaging Pricing Type is actually necessary for the functioning of the system. It was just strange that it was there before and then disappeared - although I can see why that happened now. As long as it's not required for the generation of invoices or correct addition of imaging prices, it doesn't matter. It does mean however, that on the list of prices, there are now gaps in the pricing type column, which is a bit confusing - presumably these gaps won't exist in a fresh install.

[MatthewDorner]

1. I'm still unclear on what the "Type" does for pricing item types that support it (Ward and Procedure). It some effect beyond purely descriptive, right?

2. There is actually a bug for Imaging and Lab. They're supposed to always get the default "Imaging Procedure" and "Lab Procedure" as their types but in fact they only get assigned that value when categoryChanged action is triggered, meaning if you go directly to the "Imaging Pricing" tab in your screenshot and add one, it will be blank, like your "Chest XRay" item was. This should be easy to fix.

3. Since it sounds like Ward and Procedure (edit: oops, meant Imaging and Lab) pricing types won't be editable, we could remove the lookup lists, although the way it is now won't cause any bugs, so probably not a priority.

[MatthewDorner]

from @drakemedic on Slack, regarding the problem here: "For the lab types, they are required to add lab tests to the system. There doesn't seem to be any other way to do it. Now that it is disabled in the lookups, you can't add any lab requests from a fresh install. I have one lab type available - "Full Blood Count". I need a whole bunch of other tests"

[MatthewDorner]

Working on this one now: https://github.com/MatthewDorner/hospitalrun-frontend/tree/pricing-types