Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

move from jade to pug #1159

Closed
tangollama opened this issue Sep 1, 2017 · 8 comments
Closed

move from jade to pug #1159

tangollama opened this issue Sep 1, 2017 · 8 comments
Labels
help wanted indicates that an issue is open for contributions wontfix indicates an issue/pull request will not be worked on

Comments

@tangollama
Copy link
Member

Expected behavior:
npm install with no warning

Actual behavior:
npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade

Steps to reproduce:
checkout the project
navigate to the frontend directory
npm install

Screenshots (if applicable):
N/A

OS and Browser:

@tangollama tangollama added help wanted indicates that an issue is open for contributions LOE: < 1 week labels Sep 1, 2017
@satnamiaman
Copy link

Got these warning while npm install.
Attaching screenshot
screenshot from 2017-09-02 11-27-51

@baoqchau
Copy link
Contributor

baoqchau commented Sep 3, 2017

Hi @tangollama, are we still using jade (or pug) in our project? Because I cannot find jade package in package.json and as I know, HospitalRun using Handlebars as view engine, not Jade

@guillaume-ro-fr
Copy link

Hi @baoqchau !

Here the dependancies tree :

[email protected] /Users/guillaume/Desktop/hospitalrun-frontend
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

@jbryson3
Copy link

jbryson3 commented Feb 8, 2018

I do not get this warning on MacOS with npm 5.5.1 (node 8.9.3)

The only warning I see is:
npm WARN The package electron-protocol-serve is included as both a dev and production dependency.

@baldyjohnmichael
Copy link

Mind if I work on this?

@baoqchau
Copy link
Contributor

@baldyjohnmichael go ahead

@stukalin
Copy link
Contributor

@baldyjohnmichael sure you can take over this issue. However, the problem is (sorry if I say obvious things here) that you need to go down the dependency tree and replace jade in the electron-compilers. Actually there are a couple of PRs there, but they were not merged. If you were able to push them, you'd have the issue half-done.
electron-userland/electron-compilers#34
electron-userland/electron-compilers#66

@stale
Copy link

stale bot commented Aug 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix indicates an issue/pull request will not be worked on label Aug 7, 2019
@fox1t fox1t closed this as completed Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted indicates that an issue is open for contributions wontfix indicates an issue/pull request will not be worked on
Projects
None yet
Development

No branches or pull requests

8 participants