diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 93ed39ed1f..e5fae60c0a 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -127,13 +127,14 @@ Before submitting a request, please search for similar ones in the ## Pull Requests -1. Ensure any install or build dependencies are removed before the end of the layer when doing a +1. **Don't open the PR until it's ready for review. We need to optimize build time.** +2. Ensure any install or build dependencies are removed before the end of the layer when doing a build. -2. Update the README.md with details of changes to the interface, this includes new environment +3. Update the README.md with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations and container parameters. -3. Increase the version numbers in any examples files and the README.md to the new version that this +4. Increase the version numbers in any examples files and the README.md to the new version that this Pull Request would represent. The versioning scheme we use is [SemVer](http://semver.org/). -4. You may merge the Pull Request in once you have the sign-off of two other developers, or if you +5. You may merge the Pull Request in once you have the sign-off of two other developers, or if you do not have permission to do that, you may request the second reviewer to merge it for you. ## Contributor License Agreement