-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt formatOnSave changes #59
Comments
Thanks for the nudge @jrieken. I'm on it. 🛠 |
@jrieken: Something that I have found to be lacking in the docs, at what version does this kick in? I'm guessing it's at 1.6.0, but it would be nice if an 'as of' was mentioned in the api docs. |
Understood - what we do is to fetch the version of |
@jrieken, I mean, at https://code.visualstudio.com/docs/extensionAPI/vscode-api it would be nice if each of the methods had a reference to the version in which they became/become available. |
Done in v0.5.0 |
Since we now have the
editor.formatOnSave
-setting and theonWillSaveTextDocument
event, this code should be updated. Using the new infrastructure will prevent unnecessary fs-operations, event cascades, and potential for endless write-event-write loops.See https://code.visualstudio.com/updates#_format-on-save, microsoft/vscode#12449, and microsoft/vscode#239 for more details
The text was updated successfully, but these errors were encountered: