Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt formatOnSave changes #59

Closed
jrieken opened this issue Oct 18, 2016 · 5 comments
Closed

Adopt formatOnSave changes #59

jrieken opened this issue Oct 18, 2016 · 5 comments

Comments

@jrieken
Copy link

jrieken commented Oct 18, 2016

Since we now have the editor.formatOnSave-setting and the onWillSaveTextDocument event, this code should be updated. Using the new infrastructure will prevent unnecessary fs-operations, event cascades, and potential for endless write-event-write loops.

See https://code.visualstudio.com/updates#_format-on-save, microsoft/vscode#12449, and microsoft/vscode#239 for more details

@HookyQR
Copy link
Owner

HookyQR commented Oct 18, 2016

Thanks for the nudge @jrieken. I'm on it. 🛠

@HookyQR
Copy link
Owner

HookyQR commented Oct 18, 2016

@jrieken: Something that I have found to be lacking in the docs, at what version does this kick in? I'm guessing it's at 1.6.0, but it would be nice if an 'as of' was mentioned in the api docs.

@jrieken
Copy link
Author

jrieken commented Oct 19, 2016

Understood - what we do is to fetch the version of vscode.d.ts according to the engine-property in your package.json file.

@HookyQR
Copy link
Owner

HookyQR commented Oct 22, 2016

@jrieken, I mean, at https://code.visualstudio.com/docs/extensionAPI/vscode-api it would be nice if each of the methods had a reference to the version in which they became/become available.

@HookyQR
Copy link
Owner

HookyQR commented Oct 22, 2016

Done in v0.5.0

@HookyQR HookyQR closed this as completed Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants