Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor all image components to ImageKnife and image-preview #8

Open
xymeng16 opened this issue Oct 25, 2024 · 1 comment
Open

Refactor all image components to ImageKnife and image-preview #8

xymeng16 opened this issue Oct 25, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@xymeng16
Copy link
Collaborator

xymeng16 commented Oct 25, 2024

ImageKnife is a more flexible and powerful image rendering components than the builtin Image component. It's internal caching mechanism can enhance the performance of Homogram, especially when facing tons of profile images.

image-preview can monitor the click event of the image components and to open a fullscreen view of it. Using this to provide the best image viewing experience.

@xymeng16 xymeng16 self-assigned this Oct 25, 2024
@xymeng16 xymeng16 converted this from a draft issue Oct 25, 2024
@xymeng16 xymeng16 added the enhancement New feature or request label Oct 25, 2024
@xymeng16 xymeng16 added this to the v0.1.0 milestone Oct 25, 2024
@xymeng16
Copy link
Collaborator Author

xymeng16 commented Nov 5, 2024

8adc2a4 has initially replaced Image component with image-preview, but the onClick method is buggy. It responds to clicks but nothing will be shown. Still need to debug.

@xymeng16 xymeng16 changed the title Refactor all image components to ImageKnife Refactor all image components to ImageKnife and image-preview Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

1 participant