Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile-time warning #8

Open
dmacks opened this issue Dec 15, 2019 · 0 comments
Open

Compile-time warning #8

dmacks opened this issue Dec 15, 2019 · 0 comments

Comments

@dmacks
Copy link

dmacks commented Dec 15, 2019

Compiling libGDSII-0.21 on OS X 10.13 with Apple's compiler toolchain...

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -g -O2 -MT ReadGDSIIFile.lo -MD -MP -MF .deps/ReadGDSIIFile.Tpo -c ReadGDSIIFile.cc  -fno-common -DPIC -o .libs/ReadGDSIIFile.o
ReadGDSIIFile.cc:654:50: warning: adding 'libGDSII::BYTE' (aka 'unsigned char')
      to a string does not append to the string [-Wstring-plus-int]
       *ErrMsg = new string("unknown data type " + DType);
                            ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
ReadGDSIIFile.cc:654:50: note: use array indexing to silence this warning
       *ErrMsg = new string("unknown data type " + DType);
                                                 ^
                            &                    [      ]
1 warning generated.

Should it be some sort of ostringstream (like around line 579) or other type of concatenation or sprintf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant