-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Conversation
Don't worry about that - the build bots automatically build binaries. |
|
||
def install | ||
# patched the Makefile vars to install to ${PREFIX}/libexec | ||
ohai "Building Hue from source - this process will take several minutes ..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to include this.
…ages based on pull request comments
…y. currently 'optional' - I don't think it should be required or recommended for this package.
desc "Hue is a Web interface for analyzing data with Apache Hadoop." | ||
homepage "http://gethue.com/" | ||
url "https://github.com/cloudera/hue/archive/release-3.8.1.tar.gz" | ||
# version "3.8.1" # redundant with version scanned from URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this comment.
@tdsmith Thanks for all of the comments! I'm working on a new revision, and will be back to reply soon. |
…de option. removed dependency on Homebrew Python. changed make to use 'ENV.deparallelize' instead of '-j 1'. added fix for change for SASL headers location in Mavericks. added patch for 'crl.c' on Mavericks.
Any update here? |
Ping? |
Hey Everyone, Sorry for the delay! I pushed a new commit tonight. In addition to fixes for the issues above, I included:
I'm still writing up the "tablib" pull request - I expect I'll have that out tomorrow or Thursday. Cheers, - Chris |
url "https://github.com/cloudera/hue/archive/release-3.8.1.tar.gz" | ||
sha256 "582777f567b9f4a34e4ce58cfd5ed24aff15f3e02f193e7990329d8cb0161a8a" | ||
|
||
option "with-system-openssl", "Build with the Mac OS system OpenSSL instead of the (more secure) latest Homebrew version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support this option in the core. It must use Homebrew's OpenSSL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed option to install with system OpenSSL.
Thanks for filing this upstream. Appreciate that. Hopefully we'll get a status update on that from them relatively soon - pyOpenSSL is fun to build nicely as intended/desired even when using the latest version, let alone when not 😿. |
… fix, as error message during install build doesn't ultimately affect installation or runtime
In the latest commit, I removed:
Also, Cloudera accepted the "parquet" and "pyOpenSSL" patches, so I'll be able to remove those from the formula on Hue's next release. - Chris |
depends_on "maven" => :build | ||
depends_on "openssl" | ||
|
||
patch :DATA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please submit this patch to the upstream developers of this project and add a link to the upstream patch submission and explanation of why the patch is needed in a comment in the formula file. Thanks!
…ibexec. added comment to remind us to try to remove patches on next release.
In this last commit, I removed the INSTALL_DIR patch that was fixing this issue. The patch was just changing the install directory. By default, Hue installs to "/usr/local/hue/...". Now via Homebrew it installs to "libexec/hue/...", which is fine. The remaining two patches were submitted upstream, and have been merged: cloudera/hue#206 Added a comment to the formula with links and short notes. - Chris |
# (> 3.8.1) without them. | ||
# | ||
# Syntax error in 'parquet-python' library: | ||
# https://github.com/cloudera/hue/pull/206 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to use https://github.com/cloudera/hue/pull/206.patch
and https://github.com/cloudera/hue/pull/207.patch
as patch do
URLs instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…es. use variable for MacOS SDK.
Thanks everyone for the comments. I'm still getting up to speed on Ruby + Homebrew best practices. Anything else I can do to improve future formulas, please let me know. |
Looks like 3.9.0 is out. If you update this PR and push, it'll run another build. |
@@ -0,0 +1,57 @@ | |||
class Hue < Formula | |||
desc "Hue is a Web interface for analyzing data with Apache Hadoop." | |||
homepage "http://gethue.com/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use https://
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point but gethue.com does not have https yet, it will break the page on modern browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right it breaks the page.
Ping? |
Closing due to no response; feel free to open a new PR that passes the tests. Thanks! |
This is a formula for Hue, a nice web interface for interacting with Hadoop stack applications.
The build takes a while - about 8 minutes on my 2014 Macbook Air. The installed software is about 200 MB. I'm going to look into bottling - this formula just has build-from-source for right now.
Happy to take any suggestions on formatting, installation method, etc.
Thanks!