GitDownloadStrategy: Control submodule clones

[staticfloat]

Is there a way to communicate to the GitDownloadStrategy that we don't want to clone submodules? Julia's buildsystem has moved to git submodules for dependencies (e.g. openlibm, nginx, Rmath, libuv) and I'd like to manually manage those dependencies with Homebrew. E.g. since we have an nginx formula in Homebrew, I'd like to use that nginx instead of having Julia download/build her own.

Once the install method of my formula is invoked, I can exercise control over Julia's build process (e.g. pass the proper flags to make to stop her from compiling her own nginx from the sources that have been downloaded) however I can't figure out how to exercise control over which submodules are downloaded. I would happily patch .gitmodules or somesuch if that would work, however submodules are automatically downloaded before any of my code runs, including patches. Is there a way to modify this behavior in Homebrew?

[adamv]

It will have to be done by writing code, I'm afraid. Checkout the existing download strategies for examples of how we use inheritance in them. Line 386 is where we do submodule things, will probably need to add some member flag that is checked as well.

[jacknagel]

I'll take a crack at this, looks like a good opportunity to clean up the methods in this class.

[staticfloat]

Thanks, Jack! I am so busy this quarter, it would take me weeks to get this
done.
On Feb 12, 2013 8:30 AM, "Jack Nagel" [email protected] wrote:

I'll take a crack at this, looks like a good opportunity to clean up the
methods in this class.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/17783#issuecomment-13441087.

[jacknagel]

Patches to Homebrew: https://github.com/jacknagel/homebrew/compare/git

formula-side changes:

class GitNoSubmoduleDownloadStrategy < GitDownloadStrategy
  def submodules?; false; end
end

class SomeFormula < Formula
  url '...', :using => GitNoSubmoduleDownloadStrategy

  # ...
end

I don't want to bother adding a flag to the DSL or anything yet.

[jacknagel]

Merged my patches.