portable-ruby 3.3.5

[BrewTestBot]

Created by brew bump

---

Created with brew bump-formula-pr.

• resource blocks have been checked for updates.

[Bo98]

Patch is safe to remove now. Upstream included it with Ruby 3.3.5.

It seems 3.3.5 has a change that throws deprecation for require "ostruct" so this might require some work in Homebrew/brew to support. Unfortunately it seems this falsely triggers for require "json" too as json indirectly depends on ostruct (but not in Ruby 3.4). Could backport the relevant json fix though maybe we need to think about system Ruby on Linux.

[Bo98]

Might just hack some code to globally disable those warnings over at Homebrew/brew tbh. They're useful on paper but they have caused unfixable problems given we cannot be building native extensions on the fly like upstream expect, especially when it is now covering things that are already fixed upstream but not in any released version.

[Bo98]

Will check on CI later but I think it might just be a case of replacing --disable-gems with Gem.discover_gems_on_require = false

[MikeMcQuaid]

Might just hack some code to globally disable those warnings over at Homebrew/brew tbh.

Works for me 👍🏻

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[Bo98]

Hmm looks like there's another 3.3.5 bug here:

Non-executables were installed to "/opt/homebrew/opt/portable-ruby/bin".
The offending files are:
  /opt/homebrew/opt/portable-ruby/bin/ri.lock
  /opt/homebrew/opt/portable-ruby/bin/bundler.lock
  /opt/homebrew/opt/portable-ruby/bin/rdoc.lock
  /opt/homebrew/opt/portable-ruby/bin/rdbg.lock
  /opt/homebrew/opt/portable-ruby/bin/bundle.lock
  /opt/homebrew/opt/portable-ruby/bin/syntax_suggest.lock
  /opt/homebrew/opt/portable-ruby/bin/erb.lock
  /opt/homebrew/opt/portable-ruby/bin/irb.lock
  /opt/homebrew/opt/portable-ruby/bin/bootsnap.lock

https://bugs.ruby-lang.org/issues/20721

It is already fixed for 3.3.6 (Nov 5th). Though we could backport the relevant patches (4 commits).

[p-linnane]

Let's backport so we can get this shipped. I can take a crack at it in a bit.

[Bo98]

Basically patched in the majority of 3.3.6 at this point but it is what it is.

[Bo98]

Somehow pulled a masterclass and builds on the new Intel image on the newer hardware is now over 2x faster and is now nearly as fast as arm64.

Almost seems like it's wrong.

[MikeMcQuaid]

@Bo98 nice work!