-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node 18.1.0 #100691
node 18.1.0 #100691
Conversation
npm needs to be bumped to 8.8.0, see nodejs/node#42886 |
4cd028a
to
8084c13
Compare
Thanks @branchvincent - sorry I thought the PR hadn't gone through due to a duplicate. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
This is unfortunate. Can we please reopen the PR? Was there a CI failure that blocked bumping the formula? |
Can you please add the |
@derrabus There is only a limited amount of long-timeout slots available, so CI cannot be restarted at the moment. |
Thanks, those failures were the piece of information I was looking for. 🙂 |
To summarize those logs, all runners encountered the same two issues:
|
Seems to have been tracked upstream |
The test for emscripten will pass with the flag |
#101576 update should fix |
8084c13
to
fd072bc
Compare
fd072bc
to
948ccd6
Compare
@branchvincent Do we usually fix the tests in a separate PR? I think this should be green now. |
Could we merge this? |
Still the same test error on |
node 18.2.0 has been released, bumping NPM to 8.9.0: https://github.com/nodejs/node/releases/tag/v18.2.0 |
maybe let's merge this one and fix the failures and then start 18.2.0 journey. |
only |
Created by
brew bump
Created with
brew bump-formula-pr
.resource
blocks may require updates.