Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encfs should use macfuse not osxfuse #66915

Closed
mike-kfed opened this issue Dec 14, 2020 · 3 comments
Closed

encfs should use macfuse not osxfuse #66915

mike-kfed opened this issue Dec 14, 2020 · 3 comments
Labels
outdated PR was locked due to age

Comments

@mike-kfed
Copy link

right now encfs depends on a really old version of FUSE for macOS. I know the author of osxfuse (which is now called macfuse) no longer provides the kernel module as opensource, however it still is free to download and works fine (as shown in steps to reproduce).

steps to reproduce

  • Install macfuse 4.0.4 from https://osxfuse.github.io/ manually
  • install osxfuse using brew install --cask osxfuse
  • replace the load_osxfuse binary with a symlink to the macfuse version (this should especially help Apple Silicon M1 chip users)
LOAD_MACFUSE="/Library/Filesystems/macfuse.fs/Contents/Resources/load_macfuse"
sudo rm /Library/Filesystems/osxfuse.fs/Contents/Resources/load_osxfuse
sudo ln -s $LOAD_MACFUSE /Library/Filesystems/osxfuse.fs/Contents/Resources/load_osxfuse

problem

even using my fix to load the right kernel extension, this still uses the old mount_osxfuse binary. symlinking to the new one breaks encfs (apparently it uses it somehow wrong, as the the --help output is shown)

fix

  • compile encfs against the new macfuse
  • remove osxfuse dependency
  • tell user to manually install macfuse (e.g. when path /Library/Filesystems/macfuse.fs is not found)
@carlocab
Copy link
Member

I'm not sure that's going to work, as formulae in homebrew-core cannot depend on software that is neither also on homebrew-core nor built-in on macOS (with the single exception of CLT).

I think you may wish to maintain a tap with a formula for encfs that does this. You can read up on how to do this here and here.

@SMillerDev
Copy link
Member

it still is free to download and works fine

This is not good enough for inclusion into homebrew core.

@jonchang
Copy link
Contributor

encfs is deprecated and we'll probably be removing it in the near future. See #64491 for details.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 15, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

5 participants