Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swftools --with-jpeg --with-lame failed to build on 10.13.4 #28559

Closed
jvalteren opened this issue Jun 1, 2018 · 4 comments
Closed

swftools --with-jpeg --with-lame failed to build on 10.13.4 #28559

jvalteren opened this issue Jun 1, 2018 · 4 comments
Labels
outdated PR was locked due to age stale No recent activity

Comments

@jvalteren
Copy link

jvalteren commented Jun 1, 2018

Here goes...

I ran brew update and doctor, no issues there. See gist logs here, anchored to offending error: https://gist.github.com/jvalteren/646fe6e6b576a5900dcccb456c4395ce#file-02-make-L66

I wanted to add jpeg support to swftools, so I can properly use infoqscraper (see https://github.com/cykl/infoqscraper/wiki/Setting-up), which needs it otherwise it returns the error 'No JPEG library compiled in'.

Based on issue #15910, I already deducted that I had to unlink freetype (to prevent error 'ft2build.h' file not found). Also, I had to provide the option --with-lame, otherwise it returns an error about missing lame ('lame.h' file not found). All of freetype, jpeg and lame were already installed.

So, what I ended up doing was this:

brew unlink freetype
brew install swftools --with-jpeg --with-lame

This results in the following output:

==> Downloading http://www.swftools.org/swftools-0.9.2.tar.gz
Already downloaded: /Users/jvalteren/Library/Caches/Homebrew/swftools-0.9.2.tar.gz
==> Patching
patching file configure
==> ./configure --prefix=/usr/local/Cellar/swftools/0.9.2_1
==> make
Last 15 lines from /Users/jvalteren/Library/Logs/Homebrew/swftools/02.make:
    jpeg_start_compress(&cinfo, FALSE);
                                ^
jpeg.c:331:30: error: use of undeclared identifier 'TRUE'
    jpeg_read_header(&cinfo, TRUE);
                             ^
jpeg.c:380:30: error: use of undeclared identifier 'TRUE'
    jpeg_read_header(&cinfo, TRUE);
                             ^
jpeg.c:462:30: error: use of undeclared identifier 'TRUE'
    jpeg_read_header(&cinfo, TRUE);
                             ^
11 errors generated.
make[1]: *** [jpeg.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2

READ THIS: https://docs.brew.sh/Troubleshooting

This goes beyond my skills with homebrew and make etc to fix.

I'm guessing here because I don't have a clean system to try this on, but these might be step-by-step reproduction instructions:

brew install jpeg lame freetype
brew unlink freetype
brew install swftools --with-jpeg --with-lame
@DomT4
Copy link
Member

DomT4 commented Jun 1, 2018

It'll be this issue: swftools/swftools#37. Reported upstream almost a year ago and not yet fixed.

@jvalteren
Copy link
Author

Yes, that certainly looks like it. However, I don't know how to make the suggested modification while having Homebrew build the package.

Perhaps you (or someone else) can describe necessary steps to enable this workaround?

@fxcoudert
Copy link
Member

fxcoudert commented Jun 4, 2018

On macOS 10.13, I see the following:

  • --with-jpeg fails to build with the above error
  • --with-xpdf also fails to build: xpdf/GlobalParams.cc:925:12: error: ordered comparison between pointer and zero
  • building from source without option fails, if freetype happens to be installed: swftools fails to build from source #15910

It is tempting to remove all non-working options. Maybe even the fftw option, which needs a patch and is almost never used…

@stale
Copy link

stale bot commented Jun 25, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Jun 25, 2018
@stale stale bot closed this as completed Jul 2, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 1, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

No branches or pull requests

3 participants